From: Johannes Hirte <johannes.hirte@datenkhaos.de>
To: Filipe Manana <fdmanana@gmail.com>
Cc: linux-btrfs <linux-btrfs@vger.kernel.org>
Subject: Re: unexpected truncated files
Date: Sun, 5 Apr 2020 16:51:21 +0200 [thread overview]
Message-ID: <20200405145121.GA952734@latitude> (raw)
In-Reply-To: <CAL3q7H4xya8EuBhGsX4gs8V6xdNWpJhjhJj0-KdUJhMnDjHjXQ@mail.gmail.com>
On 2020 Apr 04, Filipe Manana wrote:
> On Sat, Apr 4, 2020 at 8:52 PM Johannes Hirte
> <johannes.hirte@datenkhaos.de> wrote:
> >
> > While testing with the current 5.7 development kernel, I've encountered
> > some strange behaviour. I'm using Gentoo linux, and during updating the
> > system I got some unexpected errors. It looked like some files were
> > missing. Some investigations showed me, that files from shortly
> > installed packages were truncated to zero. So for example the config
> > files for apache webserver were affected. I've reinstalled apache,
> > verified that the config was ok and continued the system update with the
> > next package. After this, the apache config files were truncated again.
> > I've found several files from different packages that were affed too,
> > but only text files (configs, cmake-files, headers). Files which were
> > writen, are truncated by some other write operation to the filesystem.
> >
> > I'm not sure, if this is really caused by btrfs, but it's the most
> > obvious candidate. After switching back to 5.6-kernel, the truncation
> > stopped und I was able to (re-)install the packages without any trouble.
> >
> > Has anyone ideas what could cause this behaviour?
>
> It's likely due to file cloning.
>
> I found this out yesterday but hadn't sent a patch yet, was waiting
> for monday morning.
> I've just sent the patch to the list:
> https://patchwork.kernel.org/patch/11474453/
>
> Since you are only getting this with small files, it's likely the
> cloning of inline extents causing it, due to some changes in 5.7 that
> changed the file size update logic.
>
> Can you try it?
>
> Thanks.
Yes, this was it. Installing the second package for triggering the
truncation was a coincidence. Installing the first package (appache
here) and rebooting triggered the error reliable. With portage (the package
manager from Gentoo) everything is compiled and installed to a a
location on /tmp. After this, the content is copied to the target
location and seems to be done with cloning. With your patch the problem
doesn't occur anymore.
--
Regards,
Johannes Hirte
next prev parent reply other threads:[~2020-04-05 14:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-04 19:38 unexpected truncated files Johannes Hirte
2020-04-04 20:23 ` Filipe Manana
2020-04-05 14:51 ` Johannes Hirte [this message]
2020-04-06 10:51 ` Filipe Manana
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200405145121.GA952734@latitude \
--to=johannes.hirte@datenkhaos.de \
--cc=fdmanana@gmail.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox