linux-btrfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Josef Bacik <josef@toxicpanda.com>
To: linux-btrfs@vger.kernel.org, kernel-team@fb.com
Subject: [PATCH] btrfs: fix improper generation setting in parent node
Date: Mon,  6 Apr 2020 10:59:05 -0400	[thread overview]
Message-ID: <20200406145905.112078-1-josef@toxicpanda.com> (raw)

With the delayed ref throttling patches I started getting a lot of
"parent transid mismatch" messages when running my snapshot+balance
torture test.  This turned out to be because we will unconditionally set
the generation of a relocated tree block to the current transaction.

This is generally true, but especially for mid-tree nodes we could have
cow'ed the block in a previous transaction, and only actually update
it's parents in a completely different transaction.  Thus we end up with
a parent transid that is in the future of the actual block.  Fix this by
using the generation for the extent buffer we're pointing to.

Fixes: 5d4f98a28c7d ("Btrfs: Mixed back reference  (FORWARD ROLLING FORMAT CHANGE)")
Signed-off-by: Josef Bacik <josef@toxicpanda.com>
---
 fs/btrfs/relocation.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/btrfs/relocation.c b/fs/btrfs/relocation.c
index 3ca98d7e4896..d4734337127a 100644
--- a/fs/btrfs/relocation.c
+++ b/fs/btrfs/relocation.c
@@ -2303,7 +2303,7 @@ static int do_relocation(struct btrfs_trans_handle *trans,
 			btrfs_set_node_blockptr(upper->eb, slot,
 						node->eb->start);
 			btrfs_set_node_ptr_generation(upper->eb, slot,
-						      trans->transid);
+					btrfs_header_generation(eb));
 			btrfs_mark_buffer_dirty(upper->eb);
 
 			btrfs_init_generic_ref(&ref, BTRFS_ADD_DELAYED_REF,
-- 
2.24.1


             reply	other threads:[~2020-04-06 14:59 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-06 14:59 Josef Bacik [this message]
2020-04-10 15:44 ` [PATCH] btrfs: fix improper generation setting in parent node Josef Bacik
2020-04-10 16:07   ` David Sterba

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200406145905.112078-1-josef@toxicpanda.com \
    --to=josef@toxicpanda.com \
    --cc=kernel-team@fb.com \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).