From: David Sterba <dsterba@suse.cz>
To: Johannes Thumshirn <Johannes.Thumshirn@wdc.com>
Cc: Josef Bacik <josef@toxicpanda.com>,
"linux-btrfs@vger.kernel.org" <linux-btrfs@vger.kernel.org>,
"kernel-team@fb.com" <kernel-team@fb.com>
Subject: Re: [PATCH] btrfs: fix setting last_trans for reloc roots
Date: Tue, 21 Apr 2020 01:20:16 +0200 [thread overview]
Message-ID: <20200420232016.GL18421@twin.jikos.cz> (raw)
In-Reply-To: <SN4PR0401MB3598C2A93849EB046D06AAC59BD80@SN4PR0401MB3598.namprd04.prod.outlook.com>
On Thu, Apr 16, 2020 at 03:34:30PM +0000, Johannes Thumshirn wrote:
> On 16/04/2020 14:38, Johannes Thumshirn wrote:
> > This fixes a kmemleak complaint from btrfs/074, complete re-run of
> > xfstests is pending, but one down again.
> >
> > Tested-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
> >
>
> I'll take that back, I still see a leak of 'cur_trans' allocated in
> join_transaction() for btrfs/074 on a full xfstests run. The same leak
> is reported for btrfs/072 and generic/127.
I'm not sure, but the patch "btrfs: drop logs when we've aborted a
transaction" is fixing transaction handle leaks. I've added it to
misc-next, the effects have been observed in test generic/475 so it's
only a weak link, tests btrfs/074 do not stress the transaction cleanup
that much.
next prev parent reply other threads:[~2020-04-20 23:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-10 15:42 [PATCH] btrfs: fix setting last_trans for reloc roots Josef Bacik
2020-04-14 16:24 ` Filipe Manana
2020-04-16 12:24 ` David Sterba
2020-04-16 12:37 ` Johannes Thumshirn
2020-04-16 15:34 ` Johannes Thumshirn
2020-04-20 23:20 ` David Sterba [this message]
2020-04-21 8:04 ` Filipe Manana
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200420232016.GL18421@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=Johannes.Thumshirn@wdc.com \
--cc=josef@toxicpanda.com \
--cc=kernel-team@fb.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).