From: Eryu Guan <guan@eryu.me>
To: Nikolay Borisov <nborisov@suse.com>
Cc: Omar Sandoval <osandov@osandov.com>,
fstests@vger.kernel.org, kernel-team@fb.com,
linux-btrfs@vger.kernel.org, Eryu Guan <guaneryu@gmail.com>
Subject: Re: [PATCH fstests] btrfs/14{2,3}: use dm-dust instead of fail_make_request
Date: Wed, 13 May 2020 00:22:41 +0800 [thread overview]
Message-ID: <20200512162241.GC9345@desktop> (raw)
In-Reply-To: <47d3f830-bd55-c4f1-78d5-7648bc0cd44c@suse.com>
On Tue, May 12, 2020 at 09:15:50AM +0300, Nikolay Borisov wrote:
>
>
> On 15.04.20 г. 23:54 ч., Omar Sandoval wrote:
> > From: Omar Sandoval <osandov@fb.com>
> >
> > These two tests test direct I/O and buffered read repair, respectively,
> > with fail_make_request. However, by using "fail_make_request/times",
> > they rely on repair having a specific I/O pattern. My pending Btrfs
> > direct I/O refactoring patch series changes this I/O pattern and thus
> > breaks this test.
> >
> > The dm-dust target (added in v5.2) emulates a device with bad blocks
> > that are fixed when written to (like a device that remaps bad blocks).
> > This is exactly what we want for testing repair. Add some common dm-dust
> > helpers and update the tests to use dm-dust.
> >
> > Signed-off-by: Omar Sandoval <osandov@fb.com>
>
> Eryu, are you going to merge this patch ?
The dmdust part seems fine to me, could you or other btrfs folks help
review the btrfs change? That'd be appreciated!
Thanks,
Eryu
next prev parent reply other threads:[~2020-05-12 16:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-15 20:54 [PATCH fstests] btrfs/14{2,3}: use dm-dust instead of fail_make_request Omar Sandoval
2020-05-12 6:15 ` Nikolay Borisov
2020-05-12 16:22 ` Eryu Guan [this message]
2020-05-15 6:41 ` Nikolay Borisov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200512162241.GC9345@desktop \
--to=guan@eryu.me \
--cc=fstests@vger.kernel.org \
--cc=guaneryu@gmail.com \
--cc=kernel-team@fb.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=nborisov@suse.com \
--cc=osandov@osandov.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).