From: Goldwyn Rodrigues <rgoldwyn@suse.de>
To: Christoph Hellwig <hch@infradead.org>
Cc: dsterba@suse.cz, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 4/9] btrfs: Switch to iomap_dio_rw() for dio
Date: Mon, 18 May 2020 09:36:08 -0500 [thread overview]
Message-ID: <20200518143608.uv3h3ugvteefzdel@fiona> (raw)
In-Reply-To: <20200515141305.GA27936@infradead.org>
On 7:13 15/05, Christoph Hellwig wrote:
>
> FYI, generic/475 always fail on me for btrfs, due to the warnings on
> transaction abort.
>
> Anyway, I have come up with a version that seems to mostly work.
>
> The main change is that btrfs_sync_file stashes away the journal handle.
Unfortunately, this will not fly. I tested this week and found
transactions begin in writepage() etc. We could work on stashing journal
handle in those functions as well, but it looks hackish. We might revert
to it as a last resort.
In the meantime, I am trying to revert the allocations in case of an
error.
> I also had to merge parts of the ->iomap_end patch into the main iomap
> one. I also did some cleanups to my iomap changes while looking over it.
> Let me know what you thing, the tree is here:
>
> git://git.infradead.org/users/hch/misc.git btrfs-dio
>
> Gitweb:
>
> http://git.infradead.org/users/hch/misc.git/shortlog/refs/heads/btrfs-dio
--
Goldwyn
next prev parent reply other threads:[~2020-05-18 14:36 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-26 21:02 [PATCH 0/9 v7] btrfs direct-io using iomap Goldwyn Rodrigues
2020-03-26 21:02 ` [PATCH 1/9] fs: Export generic_file_buffered_read() Goldwyn Rodrigues
2020-03-26 21:02 ` [PATCH 2/9] iomap: add a filesystem hook for direct I/O bio submission Goldwyn Rodrigues
2020-03-26 21:02 ` [PATCH 3/9] iomap: Remove lockdep_assert_held() Goldwyn Rodrigues
2020-03-26 21:02 ` [PATCH 4/9] btrfs: Switch to iomap_dio_rw() for dio Goldwyn Rodrigues
2020-03-27 8:10 ` Christoph Hellwig
2020-03-27 16:13 ` Goldwyn Rodrigues
2020-05-07 6:14 ` Christoph Hellwig
2020-05-07 11:37 ` David Sterba
2020-05-07 12:10 ` Christoph Hellwig
2020-05-07 13:44 ` Goldwyn Rodrigues
2020-05-08 3:14 ` Goldwyn Rodrigues
2020-05-09 13:59 ` Christoph Hellwig
2020-05-10 4:06 ` Goldwyn Rodrigues
2020-05-12 14:58 ` Christoph Hellwig
2020-05-12 17:19 ` Goldwyn Rodrigues
2020-05-15 14:13 ` Christoph Hellwig
2020-05-18 14:36 ` Goldwyn Rodrigues [this message]
2020-05-19 20:11 ` Goldwyn Rodrigues
2020-05-20 6:11 ` Christoph Hellwig
2020-05-22 11:36 ` David Sterba
2020-05-22 12:08 ` Goldwyn Rodrigues
2020-03-26 21:02 ` [PATCH 5/9] btrfs: Use ->iomap_end() instead of btrfs_dio_data Goldwyn Rodrigues
2020-03-27 8:16 ` Christoph Hellwig
2020-03-27 16:11 ` Goldwyn Rodrigues
2020-03-26 21:02 ` [PATCH 6/9] fs: Remove dio_end_io() Goldwyn Rodrigues
2020-03-26 21:02 ` [PATCH 7/9] btrfs: remove BTRFS_INODE_READDIO_NEED_LOCK Goldwyn Rodrigues
2020-03-26 21:02 ` [PATCH 8/9] btrfs: btrfs: split btrfs_direct_IO Goldwyn Rodrigues
2020-03-26 21:02 ` [PATCH 9/9] btrfs: unlock extents in ->iomap_end() for DIO reads Goldwyn Rodrigues
2020-03-27 15:56 ` [PATCH 0/9 v7] btrfs direct-io using iomap David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200518143608.uv3h3ugvteefzdel@fiona \
--to=rgoldwyn@suse.de \
--cc=dsterba@suse.cz \
--cc=hch@infradead.org \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox