From: fdmanana@kernel.org
To: linux-btrfs@vger.kernel.org
Subject: [PATCH 1/2] Btrfs: include error on messages about failure to write space/inode caches
Date: Mon, 18 May 2020 17:34:11 +0100 [thread overview]
Message-ID: <20200518163411.18660-1-fdmanana@kernel.org> (raw)
From: Filipe Manana <fdmanana@suse.com>
Currently the error messages logged when we fail to write a free space
cache or an inode cache are not very useful as they don't mention what
was the error. So include the error number in the messages.
Signed-off-by: Filipe Manana <fdmanana@suse.com>
---
fs/btrfs/free-space-cache.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/fs/btrfs/free-space-cache.c b/fs/btrfs/free-space-cache.c
index 3c353a337b91..3f63deb9f188 100644
--- a/fs/btrfs/free-space-cache.c
+++ b/fs/btrfs/free-space-cache.c
@@ -1193,8 +1193,8 @@ static int __btrfs_wait_cache_io(struct btrfs_root *root,
if (block_group) {
#ifdef CONFIG_BTRFS_DEBUG
btrfs_err(root->fs_info,
- "failed to write free space cache for block group %llu",
- block_group->start);
+ "failed to write free space cache for block group %llu error %d",
+ block_group->start, ret);
#endif
}
}
@@ -1417,8 +1417,8 @@ int btrfs_write_out_cache(struct btrfs_trans_handle *trans,
if (ret) {
#ifdef CONFIG_BTRFS_DEBUG
btrfs_err(fs_info,
- "failed to write free space cache for block group %llu",
- block_group->start);
+ "failed to write free space cache for block group %llu error %d",
+ block_group->start, ret);
#endif
spin_lock(&block_group->lock);
block_group->disk_cache_state = BTRFS_DC_ERROR;
@@ -3997,8 +3997,8 @@ int btrfs_write_out_ino_cache(struct btrfs_root *root,
inode->i_size, true);
#ifdef CONFIG_BTRFS_DEBUG
btrfs_err(fs_info,
- "failed to write free ino cache for root %llu",
- root->root_key.objectid);
+ "failed to write free ino cache for root %llu error %d",
+ root->root_key.objectid, ret);
#endif
}
--
2.11.0
next reply other threads:[~2020-05-18 16:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-18 16:34 fdmanana [this message]
2020-05-19 13:06 ` [PATCH 1/2] Btrfs: include error on messages about failure to write space/inode caches David Sterba
2020-05-19 13:18 ` Filipe Manana
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200518163411.18660-1-fdmanana@kernel.org \
--to=fdmanana@kernel.org \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).