From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C3F4C433DF for ; Wed, 20 May 2020 06:11:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6BCDB20748 for ; Wed, 20 May 2020 06:11:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="Tz4Krj4Q" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726447AbgETGLz (ORCPT ); Wed, 20 May 2020 02:11:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34782 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725998AbgETGLz (ORCPT ); Wed, 20 May 2020 02:11:55 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EE283C061A0E for ; Tue, 19 May 2020 23:11:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=TloY3Zt+aAlZRXk3d8qYGL/3HjqaB74ylqrhxyxqiTY=; b=Tz4Krj4QGLoXr1B77gMugCWvF6 Xc2sjWUth+pyfdQKBbXJP0O/Bi9cptwr3G3YQbvh2jOikjQJh9sRyIeyuLztfJMLfin4SDReVNCuQ zu0OX7F98camhFmbXquCs2iZsoXQ/7wz7/cBj27BS+2fFGk2eghqDbio4YWLysnFpwADvmpP5hy4s iLf3tdDqURoV9V9bLKDLrgzlf8w8lZJCTqqZxja7SKsO12b9drWl7L7wIDp+tTT3N7nvim3lydu6p /bRn1Rh9KGd8FOeDsy1CPNlUBlVsxY6X/BnEQwAF2vAyh7RQNxQWUZIjb84qV6q0bgkExhKWjEMYF kE2Urknw==; Received: from hch by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1jbHxG-0004jP-Ec; Wed, 20 May 2020 06:11:50 +0000 Date: Tue, 19 May 2020 23:11:50 -0700 From: Christoph Hellwig To: Goldwyn Rodrigues Cc: Christoph Hellwig , dsterba@suse.cz, linux-btrfs@vger.kernel.org Subject: Re: [PATCH 4/9] btrfs: Switch to iomap_dio_rw() for dio Message-ID: <20200520061150.GA9695@infradead.org> References: <20200507061430.GA8939@infradead.org> <20200507113741.GJ18421@twin.jikos.cz> <20200507121037.GA25363@infradead.org> <20200508031405.br4dcibcyuoluxum@fiona> <20200509135914.GA4962@infradead.org> <20200510040601.bub3du7g5kepeakw@fiona> <20200512145807.GA23409@infradead.org> <20200512171927.tk46sbriqvhasvsq@fiona> <20200515141305.GA27936@infradead.org> <20200519201116.6qyoaxc7g2krxzzx@fiona> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200519201116.6qyoaxc7g2krxzzx@fiona> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-btrfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org On Tue, May 19, 2020 at 03:11:16PM -0500, Goldwyn Rodrigues wrote: > I finally managed to fix the reservation issue and the final tree based > on Dave's for-next is at: > https://github.com/goldwynr/linux/tree/dio-merge > > I will test it thoroughly and send another patchset. > I will still need that iomap->private! FYI, the reason why I killed ->private is that: - it turns out the current pointer one is not used at all - the integer one as used in your patch set is maybe a bit cleaner handled by a counter maintained in the aio code, as in the version of the submit hook patch in my tree. No a biggie, and we can sort that out later.