From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C036C433E2 for ; Fri, 26 Jun 2020 20:56:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DC53F2070A for ; Fri, 26 Jun 2020 20:56:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725907AbgFZU4k (ORCPT ); Fri, 26 Jun 2020 16:56:40 -0400 Received: from rin.romanrm.net ([51.158.148.128]:54864 "EHLO rin.romanrm.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725793AbgFZU4j (ORCPT ); Fri, 26 Jun 2020 16:56:39 -0400 X-Greylist: delayed 440 seconds by postgrey-1.27 at vger.kernel.org; Fri, 26 Jun 2020 16:56:39 EDT Received: from natsu (unknown [IPv6:fd39::e99e:8f1b:cfc9:ccb8]) by rin.romanrm.net (Postfix) with SMTP id 913583F8; Fri, 26 Jun 2020 20:49:12 +0000 (UTC) Date: Sat, 27 Jun 2020 01:49:12 +0500 From: Roman Mamedov To: Remi Gauvin Cc: Chris Mason , linux-btrfs Subject: Re: weekly fstrim (still) necessary? Message-ID: <20200627014912.262647f2@natsu> In-Reply-To: <5bf091c5-b769-b865-c1ab-4437565961d3@georgianit.com> References: <20200621054240.GA25387@tik.uni-stuttgart.de> <20200621235202.GA16871@tik.uni-stuttgart.de> <20200622000611.GB16871@tik.uni-stuttgart.de> <20200622140234.GA4512@tik.uni-stuttgart.de> <20200622142319.GG27795@twin.jikos.cz> <2E6403C5-072D-4E71-8501-6D90FB539C15@fb.com> <650BA0CA-449A-48DD-9E0D-A824B5D41904@fb.com> <5bf091c5-b769-b865-c1ab-4437565961d3@georgianit.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-btrfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org On Fri, 26 Jun 2020 16:18:03 -0400 Remi Gauvin wrote: > I'm probably just confusing the terminology... But could this be related > to the queued trim problems with Samsung for which they should be > blakclisted? > > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/drivers/ata/libata-core.c?id=9a9324d3969678d44b330e1230ad2c8ae67acf81 A Samsung 860 SSD that I have is the worst (compared to a dozen non-Samsung ones) when it comes to TRIM, NCQ, combination thereof, and compatibility with various SATA controllers. However it should be noted that while the commit referenced is not in the mainline kernel anymore, a narrower blacklist applying to 840 and 850 models currently is [1]. And as the report is about the 850 Pro, queued TRIM should not have been the cause, as is already blacklisted in kernel for all "Samsung SSD 850". Can check in 'dmesg' for a note about it shortly after the SSD detection to confirm. [1] https://github.com/torvalds/linux/blob/master/drivers/ata/libata-core.c#L3952 -- With respect, Roman