From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8CE82C433DF for ; Fri, 3 Jul 2020 16:22:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5E74C20870 for ; Fri, 3 Jul 2020 16:22:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726455AbgGCQWL (ORCPT ); Fri, 3 Jul 2020 12:22:11 -0400 Received: from mx2.suse.de ([195.135.220.15]:41968 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726111AbgGCQWL (ORCPT ); Fri, 3 Jul 2020 12:22:11 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 7062CAB98; Fri, 3 Jul 2020 16:22:10 +0000 (UTC) Received: by ds.suse.cz (Postfix, from userid 10065) id 771EFDA87C; Fri, 3 Jul 2020 18:21:53 +0200 (CEST) Date: Fri, 3 Jul 2020 18:21:53 +0200 From: David Sterba To: Nikolay Borisov Cc: linux-btrfs@vger.kernel.org Subject: Re: [PATCH 00/10] A bunch of misc cleanups Message-ID: <20200703162153.GF27795@twin.jikos.cz> Reply-To: dsterba@suse.cz Mail-Followup-To: dsterba@suse.cz, Nikolay Borisov , linux-btrfs@vger.kernel.org References: <20200702134650.16550-1-nborisov@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200702134650.16550-1-nborisov@suse.com> User-Agent: Mutt/1.5.23.1-rc1 (2014-03-12) Sender: linux-btrfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org On Thu, Jul 02, 2020 at 04:46:40PM +0300, Nikolay Borisov wrote: > Here's an assortment of little quality-of-life patches that I created while > looking into the raid56 code. They should bear no functional changes and have > tested them with xfstest and nothing fell over so should be rather low risk. > > Patch 1 moves code in __btrfs_map_block, essentially assigning tgtdev_map/raid_map > closet to where space for them is allocated. This also neccesiated moving the > call to sort_parity_stripes. The end result is (hopefully) slightly easier to > follow __btrfs_map_block. > > Next 5 patches cleanup minor things in raid56.c such as removing redundant checks, > making code interacting with bio_list more in line with what the rest of the > kernel is doing. Finally it's using some macros/functions instead of open-coding > them. Really just a bunch of low hanging fruit. > > Final 4 patches gradually remove all labels in btrfs_submit_compressed_read. > Current failures can be handled "inline" so to speak, without the need for > extra labels. This likely will change once the BUG_ONs are removed but we are > not there yet. > > Nikolay Borisov (10): > btrfs: Always initialize btrfs_bio::tgtdev_map/raid_map pointers > btrfs: raid56: Remove redundant check in rbio_add_io_page > btrfs: raid56: Assign bio in while() > btrfs: raid56: Remove out label in __raid56_parity_recover > btrfs: raid56: Use in_range where applicable > btrfs: raid56: Don't opencode swap() > btrfs: Remove fail label in check_compressed_csum > btrfs: Remove fail1 label in btrfs_submit_compressed_read > btrfs: Remove fail2 label from btrfs_submit_compressed_read > btrfs: Remove out label in btrfs_submit_compressed_read Except patches 4, 8, 9, 10, series merged to misc-next. We can have a look at the label/return cleanups next week, the other cleanups are good so I don't want to stall this patchset. Thanks.