From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5121C433DF for ; Tue, 7 Jul 2020 14:10:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CB2AD2064B for ; Tue, 7 Jul 2020 14:10:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727791AbgGGOKi (ORCPT ); Tue, 7 Jul 2020 10:10:38 -0400 Received: from mx2.suse.de ([195.135.220.15]:51124 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725944AbgGGOKh (ORCPT ); Tue, 7 Jul 2020 10:10:37 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 58394AF2A; Tue, 7 Jul 2020 14:10:37 +0000 (UTC) Received: by ds.suse.cz (Postfix, from userid 10065) id 5AB79DA818; Tue, 7 Jul 2020 16:10:18 +0200 (CEST) Date: Tue, 7 Jul 2020 16:10:18 +0200 From: David Sterba To: Nikolay Borisov Cc: Marcos Paulo de Souza , dsterba@suse.com, linux-btrfs@vger.kernel.org, Marcos Paulo de Souza Subject: Re: [PATCH] btrfs: ctree: Add do {} while (0) in btrfs_{set|clear}_and_info Message-ID: <20200707141018.GJ27795@twin.jikos.cz> Reply-To: dsterba@suse.cz Mail-Followup-To: dsterba@suse.cz, Nikolay Borisov , Marcos Paulo de Souza , dsterba@suse.com, linux-btrfs@vger.kernel.org, Marcos Paulo de Souza References: <20200706145936.13620-1-marcos@mpdesouza.com> <14b394fd-b338-63c9-a8a3-ba3c725f1e79@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <14b394fd-b338-63c9-a8a3-ba3c725f1e79@suse.com> User-Agent: Mutt/1.5.23.1-rc1 (2014-03-12) Sender: linux-btrfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org On Tue, Jul 07, 2020 at 11:34:12AM +0300, Nikolay Borisov wrote: > > > On 6.07.20 г. 17:59 ч., Marcos Paulo de Souza wrote: > > From: Marcos Paulo de Souza > > > > Without this change it's not possible to use these macros and having an > > if-else construction without using braces. > > > > Signed-off-by: Marcos Paulo de Souza > > This change would have been better accompanied with another one showing > intended usage. If it's part of a bigger rework then postpone it and > send everything altogether. I think the change is good as is, multi-statement macros should always be enclosed in do {} while(0);