* [PATCH] btrfs: wire up iter_file_splice_write
@ 2020-07-09 16:22 Christoph Hellwig
2020-07-09 17:24 ` David Sterba
0 siblings, 1 reply; 3+ messages in thread
From: Christoph Hellwig @ 2020-07-09 16:22 UTC (permalink / raw)
To: linux-btrfs; +Cc: Andy Lavr
btrfs implements the iter_write op and thus can use the more efficient
iov_iter based splice implementation. For now falling back to the less
efficient default is pretty harmless, but I have a pending series that
removes the default, and thus would cause btrfs to not support splice
at all.
Reported-by: Andy Lavr <andy.lavr@gmail.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>
Tested-by: Andy Lavr <andy.lavr@gmail.com>
---
fs/btrfs/file.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/fs/btrfs/file.c b/fs/btrfs/file.c
index 2520605afc256e..b0d2c976587e52 100644
--- a/fs/btrfs/file.c
+++ b/fs/btrfs/file.c
@@ -3509,6 +3509,7 @@ const struct file_operations btrfs_file_operations = {
.read_iter = generic_file_read_iter,
.splice_read = generic_file_splice_read,
.write_iter = btrfs_file_write_iter,
+ .splice_write = iter_file_splice_write,
.mmap = btrfs_file_mmap,
.open = btrfs_file_open,
.release = btrfs_release_file,
--
2.26.2
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] btrfs: wire up iter_file_splice_write
2020-07-09 16:22 [PATCH] btrfs: wire up iter_file_splice_write Christoph Hellwig
@ 2020-07-09 17:24 ` David Sterba
2020-07-09 17:26 ` Christoph Hellwig
0 siblings, 1 reply; 3+ messages in thread
From: David Sterba @ 2020-07-09 17:24 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: linux-btrfs, Andy Lavr
On Thu, Jul 09, 2020 at 06:22:06PM +0200, Christoph Hellwig wrote:
> btrfs implements the iter_write op and thus can use the more efficient
> iov_iter based splice implementation. For now falling back to the less
> efficient default is pretty harmless, but I have a pending series that
> removes the default, and thus would cause btrfs to not support splice
> at all.
Do you want this patch to go in this cycle? I have some more patches
queued and don't mind adding it if it makes development of your patchset
easier.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] btrfs: wire up iter_file_splice_write
2020-07-09 17:24 ` David Sterba
@ 2020-07-09 17:26 ` Christoph Hellwig
0 siblings, 0 replies; 3+ messages in thread
From: Christoph Hellwig @ 2020-07-09 17:26 UTC (permalink / raw)
To: dsterba, Christoph Hellwig, linux-btrfs, Andy Lavr
On Thu, Jul 09, 2020 at 07:24:28PM +0200, David Sterba wrote:
> On Thu, Jul 09, 2020 at 06:22:06PM +0200, Christoph Hellwig wrote:
> > btrfs implements the iter_write op and thus can use the more efficient
> > iov_iter based splice implementation. For now falling back to the less
> > efficient default is pretty harmless, but I have a pending series that
> > removes the default, and thus would cause btrfs to not support splice
> > at all.
>
> Do you want this patch to go in this cycle? I have some more patches
> queued and don't mind adding it if it makes development of your patchset
> easier.
That would be great.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-07-09 17:26 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-07-09 16:22 [PATCH] btrfs: wire up iter_file_splice_write Christoph Hellwig
2020-07-09 17:24 ` David Sterba
2020-07-09 17:26 ` Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).