From: David Sterba <dsterba@suse.cz>
To: trix@redhat.com
Cc: clm@fb.com, josef@toxicpanda.com, dsterba@suse.com,
linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] btrfs : fix memory leak in add_block_entry
Date: Tue, 14 Jul 2020 16:10:17 +0200 [thread overview]
Message-ID: <20200714141017.GQ3703@twin.jikos.cz> (raw)
In-Reply-To: <20200707132908.10987-1-trix@redhat.com>
On Tue, Jul 07, 2020 at 06:29:08AM -0700, trix@redhat.com wrote:
> From: Tom Rix <trix@redhat.com>
>
> clang static analysis flags this error
>
> fs/btrfs/ref-verify.c:290:3: warning: Potential leak of memory pointed to by 're' [unix.Malloc]
> kfree(be);
> ^~~~~
> The problem is in this block of code
>
> if (root_objectid) {
> struct root_entry *exist_re;
>
> exist_re = insert_root_entry(&exist->roots, re);
> if (exist_re)
> kfree(re);
> }
>
> There is no 'else' block freeing when root_objectid == 0
>
> So add an 'else'
>
> Fixes: fd708b81d972 ("Btrfs: add a extent ref verify tool")
>
> Signed-off-by: Tom Rix <trix@redhat.com>
Added to misc-next, thanks.
prev parent reply other threads:[~2020-07-14 14:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-07 13:29 [PATCH] btrfs : fix memory leak in add_block_entry trix
2020-07-14 14:10 ` David Sterba [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200714141017.GQ3703@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=clm@fb.com \
--cc=dsterba@suse.com \
--cc=josef@toxicpanda.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=trix@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox