From: David Sterba <dsterba@suse.cz>
To: Nikolay Borisov <nborisov@suse.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH RESEND] btrfs: raid56: Remove out label in __raid56_parity_recover
Date: Wed, 15 Jul 2020 15:38:41 +0200 [thread overview]
Message-ID: <20200715133841.GY3703@twin.jikos.cz> (raw)
In-Reply-To: <20200715110217.19698-1-nborisov@suse.com>
On Wed, Jul 15, 2020 at 02:02:17PM +0300, Nikolay Borisov wrote:
> There's no cleanup that occurs so we can simply return 0 directly.
>
> Signed-off-by: Nikolay Borisov <nborisov@suse.com>
Added to misc-next, thanks.
> @@ -2083,7 +2083,7 @@ static int __raid56_parity_recover(struct btrfs_raid_bio *rbio)
> */
> if (atomic_read(&rbio->error) <= rbio->bbio->max_errors) {
> __raid_recover_end_io(rbio);
> - goto out;
> + return 0;
The rest of the function can be seen from that point so readability is
not hurt.
prev parent reply other threads:[~2020-07-15 13:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-15 11:02 [PATCH RESEND] btrfs: raid56: Remove out label in __raid56_parity_recover Nikolay Borisov
2020-07-15 13:38 ` David Sterba [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200715133841.GY3703@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=nborisov@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox