Re: [PATCH 1/5] btrfs: Factor out reada loop in __reada_start_machine

David Sterba
2020-08-31T12:25:59Z

On Sat, Aug 29, 2020 at 11:06:32PM +0800, Anand Jain wrote:
> On 15/7/20 6:48 pm, Nikolay Borisov wrote:
> > This is in preparation for moving fs_devices to proper lists.
> >
> > Signed-off-by: Nikolay Borisov <nborisov@suse.com>
> > ---
> > fs/btrfs/reada.c | 21 ++++++++++++++++-----
> > 1 file changed, 16 insertions(+), 5 deletions(-)
> >
> > diff --git a/fs/btrfs/reada.c b/fs/btrfs/reada.c
> > index 243a2e44526e..aa9d24ed56d7 100644
> > --- a/fs/btrfs/reada.c
> > +++ b/fs/btrfs/reada.c
> > @@ -767,15 +767,14 @@ static void reada_start_machine_worker(struct btrfs_work *work)
> > kfree(rmw);
> > }
> >
> > -static void __reada_start_machine(struct btrfs_fs_info *fs_info)
> > +
> > +/* Try to start up to 10k READA requests for a group of devices. */
> > +static int __reada_start_for_fsdevs(struct btrfs_fs_devices *fs_devices)
>
> In my experience David doesn't prefer __ prefix for helper functions.

Right, I've updated the patch to drop the __ as there's no other
function without the underscores (unlike __reada_start_machine/reada_start_machine)