From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97515C433E0 for ; Mon, 20 Jul 2020 15:34:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7903322C9D for ; Mon, 20 Jul 2020 15:34:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728589AbgGTPeg (ORCPT ); Mon, 20 Jul 2020 11:34:36 -0400 Received: from mx2.suse.de ([195.135.220.15]:57474 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726012AbgGTPeg (ORCPT ); Mon, 20 Jul 2020 11:34:36 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id AC4A9AC24; Mon, 20 Jul 2020 15:34:41 +0000 (UTC) Received: by ds.suse.cz (Postfix, from userid 10065) id 47742DA781; Mon, 20 Jul 2020 17:34:10 +0200 (CEST) Date: Mon, 20 Jul 2020 17:34:10 +0200 From: David Sterba To: robbieko Cc: linux-btrfs@vger.kernel.org Subject: Re: [PATCH] btrfs: fix page leaks after failure to lock page for delalloc Message-ID: <20200720153410.GG3703@twin.jikos.cz> Reply-To: dsterba@suse.cz Mail-Followup-To: dsterba@suse.cz, robbieko , linux-btrfs@vger.kernel.org References: <20200720014209.11485-1-robbieko@synology.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200720014209.11485-1-robbieko@synology.com> User-Agent: Mutt/1.5.23.1-rc1 (2014-03-12) Sender: linux-btrfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org On Mon, Jul 20, 2020 at 09:42:09AM +0800, robbieko wrote: > From: Robbie Ko > > When locking pages for delalloc, we check if it's dirty and mapping still > matches, if it does not match, we will return -EAGAIN and release all > pages. > > Signed-off-by: Robbie Ko Nice catch, added to misc-next, thanks.