From: David Sterba <dsterba@suse.cz>
To: Josef Bacik <josef@toxicpanda.com>
Cc: linux-btrfs@vger.kernel.org, kernel-team@fb.com
Subject: Re: [PATCH 1/2] btrfs: don't WARN_ON() if we abort a transaction with -EROFS
Date: Tue, 21 Jul 2020 17:50:10 +0200 [thread overview]
Message-ID: <20200721155010.GM3703@twin.jikos.cz> (raw)
In-Reply-To: <20200721152428.9934-1-josef@toxicpanda.com>
On Tue, Jul 21, 2020 at 11:24:27AM -0400, Josef Bacik wrote:
> If we got some sort of corruption via a read and call
> btrfs_handle_fs_error() we'll set BTRFS_FS_STATE_ERROR on the fs and
> complain. If a subsequent trans handle trips over this it'll get -EROFS
> and then abort. However at that point we're not aborting for the
> original reason, we're aborting because we've been flipped read only.
> We do not need to WARN_ON() here.
>
> Signed-off-by: Josef Bacik <josef@toxicpanda.com>
1 and 2 added to misc-next, thanks.
prev parent reply other threads:[~2020-07-21 15:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-21 15:24 [PATCH 1/2] btrfs: don't WARN_ON() if we abort a transaction with -EROFS Josef Bacik
2020-07-21 15:24 ` [PATCH 2/2] btrfs: document special case error codes for fs errors Josef Bacik
2020-07-21 15:50 ` David Sterba [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200721155010.GM3703@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=josef@toxicpanda.com \
--cc=kernel-team@fb.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox