Re: [Cluster-devel] [PATCH 3/3] iomap: fall back to buffered writes for invalidation failures

Bob Peterson
2020-07-22T12:20:09Z

----- Original Message -----
> On Tue, Jul 21, 2020 at 08:31:57PM +0200, Christoph Hellwig wrote:
> > Failing to invalid the page cache means data in incoherent, which is
> > a very bad state for the system. Always fall back to buffered I/O
> > through the page cache if we can't invalidate mappings.
> >
> > Signed-off-by: Christoph Hellwig <hch@lst.de>
> > Acked-by: Dave Chinner <dchinner@redhat.com>
> > Reviewed-by: Goldwyn Rodrigues <rgoldwyn@suse.com>
>
> For the iomap and xfs parts,
> Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
>
> But I'd still like acks from Ted, Andreas, and Damien for ext4, gfs2,
> and zonefs, respectively.
>
> (Particularly if anyone was harboring ideas about trying to get this in
> before 5.10, though I've not yet heard anyone say that explicitly...)
>
> --D
>
> > ---
> > fs/ext4/file.c | 2 ++
> > fs/gfs2/file.c | 3 ++-
> > fs/iomap/direct-io.c | 16 +++++++++++-----
> > fs/iomap/trace.h | 1 +
> > fs/xfs/xfs_file.c | 4 ++--
> > fs/zonefs/super.c | 7 +++++--
> > 6 files changed, 23 insertions(+), 10 deletions(-)

Hi,

I think Andreas is on holiday this week, but the gfs2 portion looks good to me:

For the gfs2 portion:
Acked-by: Bob Peterson <rpeterso@redhat.com>

Regards,

Bob Peterson