From: David Sterba <dsterba@suse.cz>
To: Qu Wenruo <quwenruo.btrfs@gmx.com>
Cc: dsterba@suse.cz, Qu Wenruo <wqu@suse.com>,
linux-btrfs@vger.kernel.org,
Christian Zangl <coralllama@gmail.com>
Subject: Re: [PATCH 1/2] btrfs-progs: convert: Prevent bit overflow for cctx->total_bytes
Date: Wed, 22 Jul 2020 13:32:20 +0200 [thread overview]
Message-ID: <20200722113220.GR3703@twin.jikos.cz> (raw)
In-Reply-To: <cccdcdc8-db5a-779d-7b99-346ef14133e5@gmx.com>
On Wed, Jul 22, 2020 at 06:58:39AM +0800, Qu Wenruo wrote:
> >> Thus casting both would definitely be right, without the need to refer
> >> to the complex rule book, thus save the reviewer several minutes.
> >
> > The opposite, if you send me code that's not following known schemes or
> > idiomatic schemes I'll be highly suspicious and looking for the reasons
> > why it's that way and making sure it's correct costs way more time.
> >
> OK, then would you please remove one casting at merge time, or do I need
> to resend?
Yeah, I fix such things routinely no need to resend.
next prev parent reply other threads:[~2020-07-22 11:32 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-20 12:51 [PATCH 1/2] btrfs-progs: convert: Prevent bit overflow for cctx->total_bytes Qu Wenruo
2020-07-20 12:51 ` [PATCH 2/2] btrfs-progs: convert-tests: Add test case for multiply overflow Qu Wenruo
2020-07-20 12:53 ` [PATCH 1/2] btrfs-progs: convert: Prevent bit overflow for cctx->total_bytes Nikolay Borisov
2020-07-20 16:09 ` David Sterba
2020-07-20 23:51 ` Qu Wenruo
2020-07-21 9:58 ` David Sterba
2020-07-21 10:29 ` Qu Wenruo
2020-07-21 13:55 ` David Sterba
2020-07-21 22:58 ` Qu Wenruo
2020-07-22 11:32 ` David Sterba [this message]
2020-07-23 13:31 ` Neal Gompa
2020-07-24 0:01 ` Qu Wenruo
2020-07-28 13:14 ` Neal Gompa
2020-07-28 13:19 ` Qu Wenruo
2020-07-29 1:56 ` Neal Gompa
2020-07-29 2:30 ` Qu Wenruo
2020-07-21 13:57 ` Stefan Traby
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200722113220.GR3703@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=coralllama@gmail.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=quwenruo.btrfs@gmx.com \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox