From: David Sterba <dsterba@suse.cz>
To: Josef Bacik <josef@toxicpanda.com>
Cc: linux-btrfs@vger.kernel.org, kernel-team@fb.com,
Eric Sandeen <sandeen@redhat.com>
Subject: Re: [PATCH] btrfs: make sure SB_I_VERSION doesn't get unset by remount
Date: Thu, 30 Jul 2020 18:32:27 +0200 [thread overview]
Message-ID: <20200730163227.GI3703@twin.jikos.cz> (raw)
In-Reply-To: <20200730151809.4889-1-josef@toxicpanda.com>
On Thu, Jul 30, 2020 at 11:18:09AM -0400, Josef Bacik wrote:
> There's some inconsistency around SB_I_VERSION handling with mount and
> remount. Since we don't really want it to be off ever just work around
> this by making sure we don't get the flag cleared on remount.
Agreed. There's a tiny cpu cost of setting the bit, otherwise all
changes to i_version also change some of the times (ctime/mtime) so the
inode needs to be synced. We wouldn't save anything by disabling it.
prev parent reply other threads:[~2020-07-30 16:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-30 15:18 [PATCH] btrfs: make sure SB_I_VERSION doesn't get unset by remount Josef Bacik
2020-07-30 16:32 ` David Sterba [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200730163227.GI3703@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=josef@toxicpanda.com \
--cc=kernel-team@fb.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox