Re: [PATCH] btrfs: super.c: Set compress_level=0 when using compress=lzo

[David Sterba <dsterba@suse.cz>]

On Mon, Aug 03, 2020 at 04:55:01PM -0300, Marcos Paulo de Souza wrote:
> --- a/fs/btrfs/super.c
> +++ b/fs/btrfs/super.c
> @@ -614,6 +614,8 @@ int btrfs_parse_options(struct btrfs_fs_info *info, char *options,
>  			} else if (strncmp(args[0].from, "lzo", 3) == 0) {
>  				compress_type = "lzo";
>  				info->compress_type = BTRFS_COMPRESS_LZO;
> +				/* lzo does not expose compression levels */
> +				info->compress_level = 0;

I had that as a fixup in patches fixing the other message errors, with
info->compress_level = 1.

With level 0 it'll print

	btrfs_info(info, "%s %s compression, level %d",
		   (compress_force) ? "force" : "use",
		   compress_type, info->compress_level);


	"use lzo compression, level 0"

Which might be confusing as well, but super.c:btrfs_show_options will
not print the level in that case so I think it's fine with 0.