From: David Sterba <dsterba@suse.cz>
To: Josef Bacik <josef@toxicpanda.com>
Cc: linux-btrfs@vger.kernel.org, kernel-team@fb.com
Subject: Re: [PATCH] btrfs: check the right variable in btrfs_del_dir_entries_in_log
Date: Wed, 19 Aug 2020 18:22:36 +0200 [thread overview]
Message-ID: <20200819162236.GS2026@twin.jikos.cz> (raw)
In-Reply-To: <20200810213116.795789-1-josef@toxicpanda.com>
On Mon, Aug 10, 2020 at 05:31:16PM -0400, Josef Bacik wrote:
> With my new locking code dbench is so much faster that I tripped over a
> transaction abort from ENOSPC. This turned out to be because
> btrfs_del_dir_entries_in_log was checking for ret == -ENOSPC, but this
> function sets err on error, and returns err. So instead of properly
> marking the inode as needing a full commit, we were returning -ENOSPC
> and aborting in __btrfs_unlink_inode. Fix this by checking the proper
> variable so that we return the correct thing in the case of ENOSPC.
>
> Fixes: 4a500fd178c8 ("Btrfs: Metadata ENOSPC handling for tree log")
> Signed-off-by: Josef Bacik <josef@toxicpanda.com>
Added to misc-next, with updated changelog and comment explaining the
ENOENT.
next prev parent reply other threads:[~2020-08-19 16:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-10 21:31 [PATCH] btrfs: check the right variable in btrfs_del_dir_entries_in_log Josef Bacik
2020-08-11 10:14 ` Filipe Manana
2020-08-11 14:27 ` Josef Bacik
2020-08-11 14:38 ` Filipe Manana
2020-08-19 16:22 ` David Sterba [this message]
2020-08-20 10:29 ` Filipe Manana
2020-08-21 10:21 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200819162236.GS2026@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=josef@toxicpanda.com \
--cc=kernel-team@fb.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox