From: David Sterba <dsterba@suse.cz>
To: Qu Wenruo <wqu@suse.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] btrfs: add owner and fs_info for btrfs_device::alloc_state
Date: Thu, 20 Aug 2020 11:38:59 +0200 [thread overview]
Message-ID: <20200820093859.GV2026@twin.jikos.cz> (raw)
In-Reply-To: <20200820074246.146503-1-wqu@suse.com>
On Thu, Aug 20, 2020 at 03:42:46PM +0800, Qu Wenruo wrote:
> Commit 1c11b63eff2a ("btrfs: replace pending/pinned chunks lists with io
> tree") introduced btrfs_device::alloc_state extent io tree, but it
> doesn't initialize the fs_info and owner member.
>
> This means the following features are not properly supported:
> - Fs owner report for insert_state() error
> Without fs_info initialized, although btrfs_err() won't panic, it
> won't output which fs is causing the error.
>
> - Wrong owner for trace events
> alloc_state will get the owner as pinned extents.
>
> Fix this by assiging proper fs_info and owner for
> btrfs_device::alloc_state.
>
> Fixes: 1c11b63eff2a ("btrfs: replace pending/pinned chunks lists with io tree")
> Signed-off-by: Qu Wenruo <wqu@suse.com>
Added to misc-next, thanks.
prev parent reply other threads:[~2020-08-20 13:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-20 7:42 [PATCH] btrfs: add owner and fs_info for btrfs_device::alloc_state Qu Wenruo
2020-08-20 7:56 ` Nikolay Borisov
2020-08-20 9:38 ` David Sterba [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200820093859.GV2026@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox