From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5217FC433E1 for ; Fri, 21 Aug 2020 10:14:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 31D3B20656 for ; Fri, 21 Aug 2020 10:14:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728577AbgHUKOJ (ORCPT ); Fri, 21 Aug 2020 06:14:09 -0400 Received: from mx2.suse.de ([195.135.220.15]:48320 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727791AbgHUKOI (ORCPT ); Fri, 21 Aug 2020 06:14:08 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 89EE3AF69; Fri, 21 Aug 2020 10:14:35 +0000 (UTC) Received: by ds.suse.cz (Postfix, from userid 10065) id 8EA31DA730; Fri, 21 Aug 2020 12:13:01 +0200 (CEST) Date: Fri, 21 Aug 2020 12:13:01 +0200 From: David Sterba To: Nikolay Borisov Cc: Josef Bacik , linux-btrfs@vger.kernel.org, kernel-team@fb.com Subject: Re: [PATCH 2/2] btrfs: pretty print leaked root name Message-ID: <20200821101301.GC2026@twin.jikos.cz> Reply-To: dsterba@suse.cz Mail-Followup-To: dsterba@suse.cz, Nikolay Borisov , Josef Bacik , linux-btrfs@vger.kernel.org, kernel-team@fb.com References: <461693e5c015857e684878e99e5e65075bb97c13.1597953516.git.josef@toxicpanda.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.23.1-rc1 (2014-03-12) Sender: linux-btrfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org On Fri, Aug 21, 2020 at 10:35:38AM +0300, Nikolay Borisov wrote: > > > On 20.08.20 г. 23:00 ч., Josef Bacik wrote: > > I'm a actual human being so am incapable of converting u64 to s64 in my > > head, so add a helper to get the pretty name of a root objectid and use > > that helper to spit out the name for any special roots for leaked roots, > > so I don't have to scratch my head and figure out which root I messed up > > the refs for. > > > > Signed-off-by: Josef Bacik > > --- > > fs/btrfs/disk-io.c | 8 +++++--- > > fs/btrfs/print-tree.c | 37 +++++++++++++++++++++++++++++++++++++ > > fs/btrfs/print-tree.h | 1 + > > 3 files changed, 43 insertions(+), 3 deletions(-) > > > > diff --git a/fs/btrfs/disk-io.c b/fs/btrfs/disk-io.c > > index ac6d6fddd5f4..a7358e0f59de 100644 > > --- a/fs/btrfs/disk-io.c > > +++ b/fs/btrfs/disk-io.c > > @@ -1506,11 +1506,13 @@ void btrfs_check_leaked_roots(struct btrfs_fs_info *fs_info) > > struct btrfs_root *root; > > > > while (!list_empty(&fs_info->allocated_roots)) { > > + const char *name = btrfs_root_name(root->root_key.objectid); > > + > > root = list_first_entry(&fs_info->allocated_roots, > > struct btrfs_root, leak_list); > > - btrfs_err(fs_info, "leaked root %llu-%llu refcount %d", > > - root->root_key.objectid, root->root_key.offset, > > - refcount_read(&root->refs)); > > + btrfs_err(fs_info, "leaked root %s%lld-%llu refcount %d", > > nit: Won't this string result in some rather awkward looking strings, > such as: > > "leaked root ROOT_TREE-..." i.e shouldn't the > (objectid,offset) pair be marked with parentheses? I don't understand why need/want to print the offset here. It is from the key.offset but for a message we should print it in an understandable way.