From: David Sterba <dsterba@suse.cz>
To: Nikolay Borisov <nborisov@suse.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] btrfs: Merge inode_can_compress in inode_need_compress
Date: Wed, 26 Aug 2020 13:13:41 +0200 [thread overview]
Message-ID: <20200826111341.GD28318@twin.jikos.cz> (raw)
In-Reply-To: <20200818063056.9094-1-nborisov@suse.com>
On Tue, Aug 18, 2020 at 09:30:56AM +0300, Nikolay Borisov wrote:
> The latter is the only caller of the former. Just open code can_compress
> into need_compress and also remove the warning since it's made redundant
> by this change.
We had discussions and some disagreements in the past regarding the
need/can compression helpers
(v1) https://lore.kernel.org/linux-btrfs/20180515073622.18732-1-wqu@suse.com/
(v2) https://lore.kernel.org/linux-btrfs/20190701051225.17957-1-wqu@suse.com/
The fix got merged as there was a pending user report and bug to fix,
but I remember there's more to do.
While this patch cleans up some of the code, I don't think it's going
the right way, we have 2 semantics for the compression decision and the
helpers codify that.
I haven't read the discussions yet again and will have to do that
before merging this patch.
next prev parent reply other threads:[~2020-08-26 11:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-18 6:30 [PATCH] btrfs: Merge inode_can_compress in inode_need_compress Nikolay Borisov
2020-08-18 7:50 ` Qu Wenruo
2020-08-26 11:13 ` David Sterba [this message]
2020-08-31 20:40 ` David Sterba
2020-08-31 20:44 ` Nikolay Borisov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200826111341.GD28318@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=nborisov@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox