From: David Sterba <dsterba@suse.cz>
To: Josef Bacik <josef@toxicpanda.com>
Cc: linux-btrfs@vger.kernel.org, kernel-team@fb.com
Subject: Re: [PATCH v3 0/2] Fix init for device stats for seed devices
Date: Thu, 24 Sep 2020 17:22:24 +0200 [thread overview]
Message-ID: <20200924152224.GY6756@twin.jikos.cz> (raw)
In-Reply-To: <cover.1600809318.git.josef@toxicpanda.com>
On Tue, Sep 22, 2020 at 05:18:28PM -0400, Josef Bacik wrote:
> v2->v3:
> - fixed the name and arguments in the first patch.
> - use goto out for the error case with seed devices.
>
> v1->v2:
> - Rework initial fix to work with the new seed_list.
> - Add a follow up patch to address the fact that we were ignoring errors on
> reading the device tree.
>
> Hello,
>
> We see a lot of messages in the fleet where we use seed devices because we're
> not init'ing the stats for seed devices properly. I have an xfstest that shows
> this (which I need to update), and this patch fixes the problem. It's
> relatively straightforward, simply init the stats on seed devices at the same
> time we init them on our primary devices. Thanks,
>
> Josef
>
> Josef Bacik (2):
> btrfs: init device stats for seed devices
> btrfs: return error if we're unable to read device stats
Added to misc-next, thanks.
prev parent reply other threads:[~2020-09-24 15:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-22 21:18 [PATCH v3 0/2] Fix init for device stats for seed devices Josef Bacik
2020-09-22 21:18 ` [PATCH v3 1/2] btrfs: init " Josef Bacik
2020-09-22 21:18 ` [PATCH v3 2/2] btrfs: return error if we're unable to read device stats Josef Bacik
2020-09-24 15:22 ` David Sterba [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200924152224.GY6756@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=josef@toxicpanda.com \
--cc=kernel-team@fb.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox