From: David Sterba <dsterba@suse.cz>
To: Boris Burkov <boris@bur.io>
Cc: linux-btrfs@vger.kernel.org, kernel-team@fb.com
Subject: Re: [PATCH 2/4] btrfs: use sb state to print space_cache mount option
Date: Thu, 24 Sep 2020 19:04:06 +0200 [thread overview]
Message-ID: <20200924170406.GA6756@twin.jikos.cz> (raw)
In-Reply-To: <e7fe51d3013637cfe2bc9581983468d5940fdce5.1600282812.git.boris@bur.io>
On Thu, Sep 17, 2020 at 11:13:39AM -0700, Boris Burkov wrote:
> @@ -1870,6 +1868,13 @@ static int btrfs_remount(struct super_block *sb, int *flags, char *data)
> if (!sb_rdonly(sb) || *flags & SB_RDONLY) {
> btrfs_warn(fs_info,
> "Remounting with free space tree only supported from read-only to read-write");
> + /*
> + * if we aren't building the free space tree, reset
First letter in comments should be uppercase, unless it's a name of
function or identifier
> + * the space cache options to what they were before
> + */
> + btrfs_clear_opt(fs_info->mount_opt, FREE_SPACE_TREE);
> + if (btrfs_free_space_cache_v1_active(fs_info))
> + btrfs_set_opt(fs_info->mount_opt, SPACE_CACHE);
> create_fst = false;
next prev parent reply other threads:[~2020-09-24 17:05 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-17 18:13 [PATCH v3 0/4] btrfs: free space tree mounting fixes Boris Burkov
2020-09-17 18:13 ` [PATCH v3 1/4] btrfs: support remount of ro fs with free space tree Boris Burkov
2020-09-21 14:35 ` Josef Bacik
2020-09-24 17:02 ` David Sterba
2020-09-17 18:13 ` [PATCH 2/4] btrfs: use sb state to print space_cache mount option Boris Burkov
2020-09-21 14:50 ` Josef Bacik
2020-09-21 17:04 ` David Sterba
2020-09-21 17:13 ` Boris Burkov
2020-09-24 17:04 ` David Sterba [this message]
2020-09-17 18:13 ` [PATCH v3 3/4] btrfs: remove free space items when creating free space tree Boris Burkov
2020-09-21 14:54 ` Josef Bacik
2020-09-21 17:13 ` David Sterba
2020-09-21 18:22 ` Boris Burkov
2020-09-21 19:01 ` Josef Bacik
2020-09-24 17:07 ` David Sterba
2020-09-17 18:13 ` [PATCH 4/4] btrfs: skip space_cache v1 setup when not using it Boris Burkov
2020-09-21 14:54 ` Josef Bacik
2020-09-18 14:23 ` [PATCH v3 0/4] btrfs: free space tree mounting fixes David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200924170406.GA6756@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=boris@bur.io \
--cc=kernel-team@fb.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox