Linux Btrfs filesystem development
 help / color / mirror / Atom feed
From: David Sterba <dsterba@suse.cz>
To: Josef Bacik <josef@toxicpanda.com>
Cc: linux-btrfs@vger.kernel.org, kernel-team@fb.com
Subject: Re: [PATCH v2 0/5] New rescue mount options
Date: Tue, 29 Sep 2020 17:06:36 +0200	[thread overview]
Message-ID: <20200929150636.GI6756@twin.jikos.cz> (raw)
In-Reply-To: <cover.1601318001.git.josef@toxicpanda.com>

On Mon, Sep 28, 2020 at 02:34:52PM -0400, Josef Bacik wrote:
> And finally we have rescue=all, which simply enables ignoredatacsums,
> ignorebadroots, and notreelogreplay.  We need an easy catch-all option for
> distros to fallback on to get users the highest probability of being able to
> recover their data, so we will use rescue=all to turn on all the fanciest rescue
> options that we have, and then use the discrete options for more fine grained
> recovery.  Thanks,
> 
> Josef
> 
> Josef Bacik (5):
>   btrfs: unify the ro checking for mount options
>   btrfs: push the NODATASUM check into btrfs_lookup_bio_sums
>   btrfs: introduce rescue=ignorebadroots
>   btrfs: introduce rescue=ignoredatacsums
>   btrfs: introduce rescue=all

About the naming, the option names are quite clear but long to type. We
could have shorter aliases, eg. 'ibadroots', where 'i' is short for
'ignore'.

For completeness, we may also want to the negated options or add an
operator that will drop the bit, like

	mount -o rescue=all:^ignoredatacsums
	mount -o rescue=all,rescue=^ignoredatacsums

      parent reply	other threads:[~2020-09-29 15:07 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-28 18:34 [PATCH v2 0/5] New rescue mount options Josef Bacik
2020-09-28 18:34 ` [PATCH v2 1/5] btrfs: unify the ro checking for " Josef Bacik
2020-09-28 18:34 ` [PATCH v2 2/5] btrfs: push the NODATASUM check into btrfs_lookup_bio_sums Josef Bacik
2020-09-28 18:34 ` [PATCH v2 3/5] btrfs: introduce rescue=ignorebadroots Josef Bacik
2020-09-28 18:34 ` [PATCH v2 4/5] btrfs: introduce rescue=ignoredatacsums Josef Bacik
2020-09-29 14:57   ` David Sterba
2020-09-28 18:34 ` [PATCH v2 5/5] btrfs: introduce rescue=all Josef Bacik
2020-09-29 14:55   ` David Sterba
2020-09-29 15:06 ` David Sterba [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200929150636.GI6756@twin.jikos.cz \
    --to=dsterba@suse.cz \
    --cc=josef@toxicpanda.com \
    --cc=kernel-team@fb.com \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox