From: David Sterba <dsterba@suse.cz>
To: Goldwyn Rodrigues <rgoldwyn@suse.de>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] btrfs: use iosize while reading compressed pages
Date: Wed, 14 Oct 2020 16:12:48 +0200 [thread overview]
Message-ID: <20201014141248.GN6756@twin.jikos.cz> (raw)
In-Reply-To: <20200915154140.mlmlwmctre2prf2s@fiona>
On Tue, Sep 15, 2020 at 10:41:40AM -0500, Goldwyn Rodrigues wrote:
> While using compression, a submitted bio is mapped with a compressed bio
> which performs the read from disk, decompresses and returns uncompressed
> data to original bio. The original bio must reflect the uncompressed
> size (iosize) of the I/O to be performed, or else the page just gets the
> decompressed I/O length of data (disk_io_size). The compressed bio
> checks the extent map and get the correct length while performing the
> I/O from disk.
>
> This came up in subpage work when only compressed length of the original
> bio was filled in the page. This worked correctly for pagesize ==
> sectorsize because both compressed and uncompressed data are at pagesize
> boundaries, and would end up filling the requested page.
>
> Signed-off-by: Goldwyn Rodrigues <rgoldwyn@suse.com>
Added to misc-next, thanks.
prev parent reply other threads:[~2020-10-14 14:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-15 15:41 [PATCH] btrfs: use iosize while reading compressed pages Goldwyn Rodrigues
2020-09-28 18:07 ` Josef Bacik
2020-10-14 14:12 ` David Sterba [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201014141248.GN6756@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=rgoldwyn@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox