From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4EC17C433E7 for ; Fri, 16 Oct 2020 14:35:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E785C20866 for ; Fri, 16 Oct 2020 14:35:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2408943AbgJPOfY (ORCPT ); Fri, 16 Oct 2020 10:35:24 -0400 Received: from mx2.suse.de ([195.135.220.15]:59500 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2408868AbgJPOfX (ORCPT ); Fri, 16 Oct 2020 10:35:23 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id B00D2ADFE; Fri, 16 Oct 2020 14:35:22 +0000 (UTC) Received: by ds.suse.cz (Postfix, from userid 10065) id 5567BDA7C3; Fri, 16 Oct 2020 16:33:54 +0200 (CEST) Date: Fri, 16 Oct 2020 16:33:54 +0200 From: David Sterba To: Daniel Xu Cc: linux-btrfs@vger.kernel.org, kernel-team@fb.com, josef@toxicpanda.com, quwenruo.btrfs@gmx.com, Qu Wenruo Subject: Re: [PATCH v2] btrfs: Fix divide by zero Message-ID: <20201016143354.GU6756@twin.jikos.cz> Reply-To: dsterba@suse.cz Mail-Followup-To: dsterba@suse.cz, Daniel Xu , linux-btrfs@vger.kernel.org, kernel-team@fb.com, josef@toxicpanda.com, quwenruo.btrfs@gmx.com, Qu Wenruo References: <20201009010910.270794-1-dxu@dxuuu.xyz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201009010910.270794-1-dxu@dxuuu.xyz> User-Agent: Mutt/1.5.23.1-rc1 (2014-03-12) Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org On Thu, Oct 08, 2020 at 06:09:10PM -0700, Daniel Xu wrote: > If there's no parity and num_stripes < ncopies, an btrfs image can > trigger a divide by zero in calc_stripe_length(). > > The image (see link) was generated through fuzzing. > > Reviewed-by: Qu Wenruo > Link: https://bugzilla.kernel.org/show_bug.cgi?id=209587 For bugzillas please use Bugzilla: tag. > Signed-off-by: Daniel Xu Please write more descriptive subjects like "btrfs: tree-checker: validate number of chunk stripes and parity"