From: David Sterba <dsterba@suse.cz>
To: Anand Jain <anand.jain@oracle.com>
Cc: linux-btrfs@vger.kernel.org, Josef Bacik <josef@toxicpanda.com>
Subject: Re: [PATCH v10 2/3] btrfs: create read policy framework
Date: Thu, 29 Oct 2020 19:53:31 +0100 [thread overview]
Message-ID: <20201029185331.GS6756@twin.jikos.cz> (raw)
In-Reply-To: <6cf180d094035e0d9cd6544f60b80d79957a17d9.1603884513.git.anand.jain@oracle.com>
On Wed, Oct 28, 2020 at 09:14:46PM +0800, Anand Jain wrote:
> @@ -5485,7 +5486,19 @@ static int find_live_mirror(struct btrfs_fs_info *fs_info,
> else
> num_stripes = map->num_stripes;
>
> - preferred_mirror = first + current->pid % num_stripes;
> + switch (fs_info->fs_devices->read_policy) {
> + default:
> + /*
> + * Shouldn't happen, just warn and use pid instead of failing.
> + */
> + btrfs_warn_rl(fs_info,
> + "unknown read_policy type %u, fallback to pid",
> + fs_info->fs_devices->read_policy);
So this would flood the system log with useless messages once this
happens. We should really reset it to pid or whatever default we choose.
Fixed.
> + fallthrough;
> + case BTRFS_READ_POLICY_PID:
> + preferred_mirror = first + current->pid % num_stripes;
This is in the original code, but this should really use ( ) to make the
precedence clear.
next prev parent reply other threads:[~2020-10-29 18:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-28 13:14 [PATCH v10 resend 0/3] readmirror feature (read_policy sysfs and in-memory only approach) Anand Jain
2020-10-28 13:14 ` [PATCH v10 1/3] btrfs: add btrfs_strmatch helper Anand Jain
2020-10-29 18:35 ` David Sterba
2020-10-28 13:14 ` [PATCH v10 2/3] btrfs: create read policy framework Anand Jain
2020-10-29 18:53 ` David Sterba [this message]
2020-10-28 13:14 ` [PATCH v10 3/3] btrfs: create read policy sysfs attribute, pid Anand Jain
2020-10-29 16:45 ` David Sterba
2020-10-29 19:30 ` Anand Jain
2020-10-29 19:30 ` David Sterba
-- strict thread matches above, loose matches on Subject: below --
2020-10-28 4:25 [PATCH v10 0/3] readmirror feature (read_policy sysfs and in-memory only approach) Anand Jain
2020-10-28 4:25 ` [PATCH v10 2/3] btrfs: create read policy framework Anand Jain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201029185331.GS6756@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=anand.jain@oracle.com \
--cc=josef@toxicpanda.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox