From: David Sterba <dsterba@suse.cz>
To: Qu Wenruo <wqu@suse.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] btrfs: fix build warning due to u64 devided by u32 for 32bit arch
Date: Mon, 2 Nov 2020 16:03:29 +0100 [thread overview]
Message-ID: <20201102150329.GC6756@twin.jikos.cz> (raw)
In-Reply-To: <20201102073114.66750-1-wqu@suse.com>
On Mon, Nov 02, 2020 at 03:31:14PM +0800, Qu Wenruo wrote:
> [BUG]
> When building the kernel with subpage preparation patches, 32bit arches
> will complain about the following linking error:
>
> ld: fs/btrfs/extent_io.o: in function `release_extent_buffer':
> fs/btrfs/extent_io.c:5340: undefined reference to `__udivdi3'
>
> [CAUSE]
> For 32bits, dividing u64 with u32 need to call div_u64(), not directly
> call u64 / u32.
>
> [FIX]
> Instead of calling the div_u64() macros, here we introduce a helper,
> btrfs_sector_shift(), to calculate the sector shift, and we just do bit
> shift to avoid executing the expensive division instruction.
I've refreshed and pushed the series adding fs_info::sectorsize_bits so
you can use it for the subpage patches.
prev parent reply other threads:[~2020-11-02 15:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-02 7:31 [PATCH] btrfs: fix build warning due to u64 devided by u32 for 32bit arch Qu Wenruo
2020-11-02 13:54 ` David Sterba
2020-11-02 14:14 ` Qu Wenruo
2020-11-02 15:03 ` David Sterba [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201102150329.GC6756@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox