Re: [PATCH 05/10] btrfs: precalculate checksums per leaf once

[David Sterba <dsterba@suse.cz>]

On Mon, Nov 02, 2020 at 04:24:45PM +0100, David Sterba wrote:
> On Mon, Nov 02, 2020 at 10:27:25PM +0800, Qu Wenruo wrote:
> > On 2020/10/29 下午10:27, David Sterba wrote:
> > > -	csum_size = BTRFS_MAX_ITEM_SIZE(fs_info);
> > > -	num_csums_per_leaf = div64_u64(csum_size,
> > > -			(u64)btrfs_super_csum_size(fs_info->super_copy));
> > >  	num_csums = csum_bytes >> fs_info->sectorsize_bits;
> > > -	num_csums += num_csums_per_leaf - 1;
> > > -	num_csums = div64_u64(num_csums, num_csums_per_leaf);
> > > -	return num_csums;
> > > +	return DIV_ROUND_UP_ULL(num_csums, fs_info->csums_per_leaf);
> > 
> > Since it's just a DIV_ROUND_UP_ULL() call, can we make it inline?
> 
> Good point, but i'll check first if this does not bloat code due to
> inlining. As it's called once in all callers, the overhead of call is
> not a problem.

On a release config it adds about 40 bytes in resulting asm and reduces
some stack usage due to the removed calls, I guess this speaks in favor
of inlining so I'll switch it. Thanks.