Linux Btrfs filesystem development
 help / color / mirror / Atom feed
From: David Sterba <dsterba@suse.cz>
To: Josef Bacik <josef@toxicpanda.com>
Cc: linux-btrfs@vger.kernel.org, kernel-team@fb.com
Subject: Re: [PATCH 0/8] Locking cleanups and lockdep fix
Date: Thu, 12 Nov 2020 19:18:16 +0100	[thread overview]
Message-ID: <20201112181816.GV6756@twin.jikos.cz> (raw)
In-Reply-To: <cover.1604697895.git.josef@toxicpanda.com>

On Fri, Nov 06, 2020 at 04:27:28PM -0500, Josef Bacik wrote:
> Hello,
> 
> Filipe reported a lockdep splat that he hit on btrfs/187, but honestly could be
> hit anywhere we do readdir on a sufficiently large fs.  Fixing this is fairly
> straightforward, but enabled me to do a lot of extra cleanups, especially now
> that my other locking fixes have been merged.  The first two patches are to
> address the lockdep problem.  The followup patches are cleaning out the
> recursive locking support, which we no longer require.  I would have separated
> this work, but btrfs_next_old_leaf was a heavy user of this, so it would be
> annoying to take separately, hence putting it all together.  Thanks,
> 
> Josef
> 
> Josef Bacik (8):
>   btrfs: cleanup the locking in btrfs_next_old_leaf
>   btrfs: unlock to current level in btrfs_next_old_leaf
>   btrfs: kill path->recurse
>   btrfs: remove the recursion handling code in locking.c
>   btrfs: remove __btrfs_read_lock_root_node
>   btrfs: use btrfs_tree_read_lock in btrfs_search_slot
>   btrfs: remove the recurse parameter from __btrfs_tree_read_lock
>   btrfs: remove ->recursed from extent_buffer

Added to misc-next, with some minor updates in changelogs. Seems that
this should remove all leftovers after the locking switch.

      parent reply	other threads:[~2020-11-12 18:20 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-06 21:27 [PATCH 0/8] Locking cleanups and lockdep fix Josef Bacik
2020-11-06 21:27 ` [PATCH 1/8] btrfs: cleanup the locking in btrfs_next_old_leaf Josef Bacik
2020-11-09 10:06   ` Filipe Manana
2020-11-06 21:27 ` [PATCH 2/8] btrfs: unlock to current level " Josef Bacik
2020-11-09 10:12   ` Filipe Manana
2020-11-06 21:27 ` [PATCH 3/8] btrfs: kill path->recurse Josef Bacik
2020-11-09 10:19   ` Filipe Manana
2020-11-06 21:27 ` [PATCH 4/8] btrfs: remove the recursion handling code in locking.c Josef Bacik
2020-11-09 10:20   ` Filipe Manana
2020-11-11 14:14   ` David Sterba
2020-11-11 14:29   ` David Sterba
2020-11-11 14:43     ` Josef Bacik
2020-11-11 14:59       ` David Sterba
2020-11-06 21:27 ` [PATCH 5/8] btrfs: remove __btrfs_read_lock_root_node Josef Bacik
2020-11-09 10:20   ` Filipe Manana
2020-11-06 21:27 ` [PATCH 6/8] btrfs: use btrfs_tree_read_lock in btrfs_search_slot Josef Bacik
2020-11-09 10:21   ` Filipe Manana
2020-11-06 21:27 ` [PATCH 7/8] btrfs: remove the recurse parameter from __btrfs_tree_read_lock Josef Bacik
2020-11-09 10:22   ` Filipe Manana
2020-11-06 21:27 ` [PATCH 8/8] btrfs: remove ->recursed from extent_buffer Josef Bacik
2020-11-09 10:23   ` Filipe Manana
2020-11-12 18:18 ` David Sterba [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201112181816.GV6756@twin.jikos.cz \
    --to=dsterba@suse.cz \
    --cc=josef@toxicpanda.com \
    --cc=kernel-team@fb.com \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox