From: David Sterba <dsterba@suse.cz>
To: Nikolay Borisov <nborisov@suse.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] btrfs: Rename __set_extent_bit to set_extent_bit
Date: Thu, 12 Nov 2020 20:21:08 +0100 [thread overview]
Message-ID: <20201112192108.GX6756@twin.jikos.cz> (raw)
In-Reply-To: <20201105090800.19098-1-nborisov@suse.com>
On Thu, Nov 05, 2020 at 11:08:00AM +0200, Nikolay Borisov wrote:
> There are only 2 direct calls to set_extent_bit outside of extent-io - in
> btrfs_find_new_delalloc_bytes and btrfs_truncate_block, the rest are thin wrappers
> around __set_extent_bit. This adds unnecessary indirection and just makes it
> more annoying when looking at the various extent bit manipulation functions.
> This patch renames __set_extent_bit to set_extent_bit effectively removing
> a level of indirection. No functional changes.
Makes sense, we can avoid the raw calls to set_extent_bit by adding the
static inline wrappers set_extent_bit_noreserve and
set_extent_bit_delalloc_new. Qu has some cleanups in the io tree helpers
so further cleanups can be done and I'll add this patch to misc-next as
it's a good first step.
prev parent reply other threads:[~2020-11-12 19:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-05 9:08 [PATCH] btrfs: Rename __set_extent_bit to set_extent_bit Nikolay Borisov
2020-11-12 19:21 ` David Sterba [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201112192108.GX6756@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=nborisov@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox