From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 94FD4C2D0E4 for ; Mon, 23 Nov 2020 19:45:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6657920727 for ; Mon, 23 Nov 2020 19:45:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729493AbgKWTpf (ORCPT ); Mon, 23 Nov 2020 14:45:35 -0500 Received: from mx2.suse.de ([195.135.220.15]:39720 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728982AbgKWTpe (ORCPT ); Mon, 23 Nov 2020 14:45:34 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 66FFAAC75; Mon, 23 Nov 2020 19:45:33 +0000 (UTC) Received: by ds.suse.cz (Postfix, from userid 10065) id 1E6F2DA818; Mon, 23 Nov 2020 20:43:45 +0100 (CET) Date: Mon, 23 Nov 2020 20:43:45 +0100 From: David Sterba To: fdmanana@kernel.org Cc: linux-btrfs@vger.kernel.org Subject: Re: [PATCH] btrfs: do nofs allocations when adding and removing qgroup relations Message-ID: <20201123194345.GN8669@twin.jikos.cz> Reply-To: dsterba@suse.cz Mail-Followup-To: dsterba@suse.cz, fdmanana@kernel.org, linux-btrfs@vger.kernel.org References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23.1-rc1 (2014-03-12) Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org On Mon, Nov 23, 2020 at 06:30:54PM +0000, fdmanana@kernel.org wrote: > From: Filipe Manana > > When adding or removing a qgroup relation we are doing a GFP_KERNEL > allocation which is not safe because we are holding a transaction > handle open and that can make us deadlock if the allocator needs to > recurse into the filesystem. So just surround those calls with a > nofs context. > > Signed-off-by: Filipe Manana Added to misc-next, thanks.