From: David Sterba <dsterba@suse.cz>
To: Nikolay Borisov <nborisov@suse.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 3/3] btrfs: Remove inode cache feature
Date: Fri, 27 Nov 2020 17:30:01 +0100 [thread overview]
Message-ID: <20201127163001.GA6430@twin.jikos.cz> (raw)
In-Reply-To: <20201126131039.3441290-4-nborisov@suse.com>
On Thu, Nov 26, 2020 at 03:10:39PM +0200, Nikolay Borisov wrote:
> It's been deprecated and never really used so simply remove it.
>
> Signed-off-by: Nikolay Borisov <nborisov@suse.com>
> ---
> fs/btrfs/Makefile | 2 +-
> fs/btrfs/ctree.h | 15 +-
> fs/btrfs/disk-io.c | 23 --
> fs/btrfs/free-space-cache.c | 177 ------------
> fs/btrfs/free-space-cache.h | 6 -
> fs/btrfs/inode-map.c | 527 ------------------------------------
> fs/btrfs/inode-map.h | 14 -
> fs/btrfs/inode.c | 11 -
> fs/btrfs/ioctl.c | 1 -
> fs/btrfs/relocation.c | 1 -
> fs/btrfs/super.c | 8 -
> fs/btrfs/transaction.c | 19 --
> fs/btrfs/tree-log.c | 1 -
> 13 files changed, 3 insertions(+), 802 deletions(-)
> delete mode 100644 fs/btrfs/inode-map.c
> delete mode 100644 fs/btrfs/inode-map.h
This still left some bits, eg. prototypes of load_free_ino_cache and
btrfs_write_out_ino_cache (grep for ino_cache).
> --- a/fs/btrfs/super.c
> +++ b/fs/btrfs/super.c
> @@ -874,12 +874,6 @@ int btrfs_parse_options(struct btrfs_fs_info *info, char *options,
> case Opt_inode_cache:
> btrfs_warn(info,
> "the 'inode_cache' option is deprecated and will have no effect from 5.11");
> - btrfs_set_pending_and_info(info, INODE_MAP_CACHE,
> - "enabling inode map caching");
> - break;
> - case Opt_noinode_cache:
This needs to stay as well, but can be merged with the above.
Also definition of Opt_inode_cache should be moved to the deprecated
section in super.c.
There are some uses of BTRFS_FREE_INO_OBJECTID, some of them can be
removed but I'd rather do that as separate patches as it's affecting
code flow. The main removal part is done with the above fixups.
next prev parent reply other threads:[~2020-11-27 16:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-26 13:10 [PATCH 0/3] Remove deprecated inode cache feature Nikolay Borisov
2020-11-26 13:10 ` [PATCH 1/3] btrfs: Move btrfs_find_highest_objectid/btrfs_find_free_objectid to disk-io.c Nikolay Borisov
2020-11-26 13:10 ` [PATCH 2/3] btrfs: Replace calls to btrfs_find_free_ino with btrfs_find_free_objectid Nikolay Borisov
2020-11-26 13:10 ` [PATCH 3/3] btrfs: Remove inode cache feature Nikolay Borisov
2020-11-27 16:30 ` David Sterba [this message]
2020-11-26 15:31 ` [PATCH 0/3] Remove deprecated " David Sterba
2020-11-26 16:00 ` Nikolay Borisov
2020-11-27 14:58 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201127163001.GA6430@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=nborisov@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox