From: Roman Mamedov <rm@romanrm.net>
To: Josef Bacik <josef@toxicpanda.com>
Cc: linux-btrfs@vger.kernel.org, kernel-team@fb.com
Subject: Re: [PATCH] btrfs: do not allow -o compress-force to override per-inode settings
Date: Mon, 30 Nov 2020 19:08:05 +0500 [thread overview]
Message-ID: <20201130190805.48779810@natsu> (raw)
In-Reply-To: <a3cd057e747862eb7027ac6318bd26c6c36e0c49.1606743972.git.josef@toxicpanda.com>
On Mon, 30 Nov 2020 08:46:21 -0500
Josef Bacik <josef@toxicpanda.com> wrote:
> However some time later we got chattr -c, which is a user way of
> indicating that the file shouldn't be compressed. This is at odds with
> -o compress-force. We should be honoring what the user wants, which is
> to disable compression.
But chattr -c only removes the previously set chattr +c. There's no
"negative-c" to be forced by user in attributes. And +c is already unset on all
files by default. Unless I'm missing something? Thanks
--
With respect,
Roman
next prev parent reply other threads:[~2020-11-30 14:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-30 13:46 [PATCH] btrfs: do not allow -o compress-force to override per-inode settings Josef Bacik
2020-11-30 14:08 ` Roman Mamedov [this message]
2020-11-30 14:27 ` Amy Parker
2020-11-30 14:50 ` Josef Bacik
2020-11-30 15:01 ` Roman Mamedov
2020-11-30 15:10 ` Josef Bacik
2020-11-30 15:17 ` Roman Mamedov
2020-11-30 15:04 ` Hugo Mills
2020-11-30 15:12 ` Josef Bacik
2020-11-30 17:28 ` sys
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201130190805.48779810@natsu \
--to=rm@romanrm.net \
--cc=josef@toxicpanda.com \
--cc=kernel-team@fb.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox