From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1C9AC64E7B for ; Tue, 1 Dec 2020 17:48:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4846020870 for ; Tue, 1 Dec 2020 17:48:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404093AbgLARr2 (ORCPT ); Tue, 1 Dec 2020 12:47:28 -0500 Received: from mx2.suse.de ([195.135.220.15]:48086 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726104AbgLARr1 (ORCPT ); Tue, 1 Dec 2020 12:47:27 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 9E8B1AC2D; Tue, 1 Dec 2020 17:46:46 +0000 (UTC) Received: by ds.suse.cz (Postfix, from userid 10065) id 8A6EADA7D2; Tue, 1 Dec 2020 18:45:14 +0100 (CET) Date: Tue, 1 Dec 2020 18:45:14 +0100 From: David Sterba To: Qu Wenruo Cc: linux-btrfs@vger.kernel.org Subject: Re: [PATCH v2 0/4] btrfs-progs: check: add the ability to repair extent item generation corruption Message-ID: <20201201174514.GO6430@twin.jikos.cz> Reply-To: dsterba@suse.cz Mail-Followup-To: dsterba@suse.cz, Qu Wenruo , linux-btrfs@vger.kernel.org References: <20200811114451.28862-1-wqu@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200811114451.28862-1-wqu@suse.com> User-Agent: Mutt/1.5.23.1-rc1 (2014-03-12) Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org On Tue, Aug 11, 2020 at 07:44:47PM +0800, Qu Wenruo wrote: > Although we have introduced the check ability to detect bad extent item > generation, there is no repair ability. > > I thought it would be rare to hit, but real world cases prove I'm a > total idiot. > > So this patchset will add the ability to repair, for both lowmem mode > and original mode, along with enhanced test images. > > There is also a bug fix for original mode, which fails to detect such > problem if it's a tree block. > > Changelog: > v2: > - Fix a type in the subject of the 4th patch > - Fix a bracket for for a logical and and bit and > The old code is fine and bit and has higher priority, but > the bracket is intended to make that higher priority more obvious. > > Qu Wenruo (4): > btrfs-progs: check/lowmem: add the ability to repair extent item > generation > btrfs-progs: check/original: don't reset extent generation for > check_block() > btrfs-progs: check/original: add the ability to repair extent item > generation > btrfs-progs: tests/fsck: enhance invalid extent item generation test > cases Added to devel, thanks.