From: David Sterba <dsterba@suse.cz>
To: Zhihao Cheng <chengzhihao1@huawei.com>
Cc: clm@fb.com, josef@toxicpanda.com, dsterba@suse.com,
linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org,
yi.zhang@huawei.com
Subject: Re: [PATCH] btrfs: free-space-cache: Fix error return code in __load_free_space_cache
Date: Fri, 4 Dec 2020 18:52:06 +0100 [thread overview]
Message-ID: <20201204175206.GZ6430@twin.jikos.cz> (raw)
In-Reply-To: <20201120010804.440598-1-chengzhihao1@huawei.com>
On Fri, Nov 20, 2020 at 09:08:04AM +0800, Zhihao Cheng wrote:
> Fix to return the error code(instead always 0) when memory allocating
> failed in __load_free_space_cache().
This lacks the analysis of consequences, so there's only one caller and
that will treat values <=0 as 'cache not loaded'. There's no functional
change but otherwise the error values should be there for clarity.
Changelog updated.
> Fixes: a67509c30079f4c50 ("Btrfs: add a io_ctl struct and helpers ...")
BTW, please don't trim the patch subject in the Fixes line.
prev parent reply other threads:[~2020-12-04 17:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-20 1:08 [PATCH] btrfs: free-space-cache: Fix error return code in __load_free_space_cache Zhihao Cheng
2020-12-04 17:43 ` David Sterba
2020-12-04 17:52 ` David Sterba [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201204175206.GZ6430@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=chengzhihao1@huawei.com \
--cc=clm@fb.com \
--cc=dsterba@suse.com \
--cc=josef@toxicpanda.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=yi.zhang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox