Re: [PATCH v2 1/2] btrfs-progs: common: introduce fmt_print_start_object

[Sidong Yang <realwakka@gmail.com>]

On Thu, Dec 10, 2020 at 09:28:47PM +0100, David Sterba wrote:
> On Wed, Nov 11, 2020 at 04:39:08PM +0000, Sidong Yang wrote:
> > Introduce a new function that can be used when you need to print an json
> > object in command like "device stats".
> > 
> > Signed-off-by: Sidong Yang <realwakka@gmail.com>
> > ---
> >  common/format-output.c | 20 ++++++++++++++++++++
> >  common/format-output.h |  3 +++
> >  2 files changed, 23 insertions(+)
> > 
> > diff --git a/common/format-output.c b/common/format-output.c
> > index 8df93ecb..f31e7259 100644
> > --- a/common/format-output.c
> > +++ b/common/format-output.c
> > @@ -213,6 +213,26 @@ void fmt_print_end_group(struct format_ctx *fctx, const char *name)
> >  	}
> >  }
> >  
> > +void fmt_print_start_object(struct format_ctx *fctx)
> > +{
> > +	if (bconf.output_format == CMD_FORMAT_JSON) {
> > +		fmt_separator(fctx);
> > +		fmt_inc_depth(fctx);
> > +		fctx->memb[fctx->depth] = 0;
> > +		putchar('{');
> > +	}
> > +}

Hi David. Thanks for review.
> 
> This duplicates what fmt_print_start_group and fmt_print_end_group do,
> so these should be extended to handle when 'name' is NULL and print only
> the [ or {.

I think it's good to extend fmt_print_start_group. I'll retry with it.

Thanks,
Sidong