From: David Sterba <dsterba@suse.cz>
To: Josef Bacik <josef@toxicpanda.com>
Cc: linux-btrfs@vger.kernel.org, kernel-team@fb.com
Subject: Re: [PATCH] btrfs-progs: only spit out the parent or ref root for ref mismatches
Date: Fri, 11 Dec 2020 17:32:29 +0100 [thread overview]
Message-ID: <20201211163229.GL6430@twin.jikos.cz> (raw)
In-Reply-To: <26927d5268dc42db5ba131dd80b190d474bd596f.1605800521.git.josef@toxicpanda.com>
On Thu, Nov 19, 2020 at 10:42:12AM -0500, Josef Bacik wrote:
> While debugging some corruption, I got confused because it appeared as
> if we had an invalid parent set on a extent reference, because of this
> message
>
> tree backref 67014213632 parent 5 root 5 not found in extent tree
>
> But it turns out that parent and the root are a union, and we were just
> printing it out regardless of the type of backref it was. Fix the error
> message to be consistent with the other mismatch messages, simply print
> parent or root, depending on the ref type.
>
> Signed-off-by: Josef Bacik <josef@toxicpanda.com>
Added to devel, thanks.
prev parent reply other threads:[~2020-12-11 17:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-19 15:42 [PATCH] btrfs-progs: only spit out the parent or ref root for ref mismatches Josef Bacik
2020-12-11 16:32 ` David Sterba [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201211163229.GL6430@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=josef@toxicpanda.com \
--cc=kernel-team@fb.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox