From: David Sterba <dsterba@suse.cz>
To: Josef Bacik <josef@toxicpanda.com>
Cc: linux-btrfs@vger.kernel.org, kernel-team@fb.com
Subject: Re: [PATCH] btrfs-progs: print the eb flags for nodes as well
Date: Fri, 11 Dec 2020 17:48:23 +0100 [thread overview]
Message-ID: <20201211164823.GM6430@twin.jikos.cz> (raw)
In-Reply-To: <15066ba6ad8acaff53242f7cc4580874c42ce411.1605802617.git.josef@toxicpanda.com>
On Thu, Nov 19, 2020 at 11:17:04AM -0500, Josef Bacik wrote:
> While debugging a corruption problem I realized we don't spit out the
> flags for nodes, which is needed when debugging relocation problems so
> we know which nodes are the RELOC root items and which are the actual fs
> tree's items. Fix this by unifying the header printing helper so both
> leaf's and nodes get the same information printed out.
This newly prints one more line for node, like
node 41070940160 level 1 items 34 free space 87 generation 7709536 owner ROOT_TREE
node 41070940160 flags 0x1(WRITTEN) backref revision 1
the same already exists for leaves
leaf 41070944256 items 12 free space 515 generation 7709536 owner ROOT_TREE
leaf 41070944256 flags 0x1(WRITTEN) backref revision 1
I think this is ok though it would be better to have that on one line.
That the offset block address is duplicated should be enough for
grepping or matching against other data, the line would be overly long
otherwise.
> Signed-off-by: Josef Bacik <josef@toxicpanda.com>
Added to devel, thanks.
prev parent reply other threads:[~2020-12-11 18:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-19 16:17 [PATCH] btrfs-progs: print the eb flags for nodes as well Josef Bacik
2020-12-11 16:48 ` David Sterba [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201211164823.GM6430@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=josef@toxicpanda.com \
--cc=kernel-team@fb.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox