From: David Sterba <dsterba@suse.cz>
To: Josef Bacik <josef@toxicpanda.com>
Cc: linux-btrfs@vger.kernel.org, kernel-team@fb.com
Subject: Re: [PATCH] btrfs-progs: fix invalid size check for extent items
Date: Fri, 11 Dec 2020 18:00:41 +0100 [thread overview]
Message-ID: <20201211170041.GN6430@twin.jikos.cz> (raw)
In-Reply-To: <c85b0bbcfff13bafec48f8cd266fb73b345c43c3.1605820453.git.josef@toxicpanda.com>
On Thu, Nov 19, 2020 at 04:14:20PM -0500, Josef Bacik wrote:
> While trying to run down a corruption problem I needed to use
> btrfs-image to generate known good states in between tests. At some
> point this started failing with
>
> either extent tree is corrupted or deprecated extent ref format
>
> This is because the fs had an extent item that was large enough that it
> no longer had inline extent references, they were all keyed extent
> references. The check is bogus, we can have extent items that are >=
> the extent item size, not just > than the extent item size. Fix the
> check so that we can generate metadata dumps properly.
>
> Signed-off-by: Josef Bacik <josef@toxicpanda.com>
Added to devel, thanks.
prev parent reply other threads:[~2020-12-11 18:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-19 21:14 [PATCH] btrfs-progs: fix invalid size check for extent items Josef Bacik
2020-12-11 17:00 ` David Sterba [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201211170041.GN6430@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=josef@toxicpanda.com \
--cc=kernel-team@fb.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox