From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-btrfs-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00,
	HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,
	USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id C6432C4361B
	for <linux-btrfs@archiver.kernel.org>; Fri, 11 Dec 2020 19:29:00 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by mail.kernel.org (Postfix) with ESMTP id 2BB2F23BAB
	for <linux-btrfs@archiver.kernel.org>; Fri, 11 Dec 2020 19:28:59 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S2405713AbgLKRtH (ORCPT <rfc822;linux-btrfs@archiver.kernel.org>);
        Fri, 11 Dec 2020 12:49:07 -0500
Received: from mx2.suse.de ([195.135.220.15]:37936 "EHLO mx2.suse.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S2405727AbgLKRsr (ORCPT <rfc822;linux-btrfs@vger.kernel.org>);
        Fri, 11 Dec 2020 12:48:47 -0500
X-Virus-Scanned: by amavisd-new at test-mx.suse.de
Received: from relay2.suse.de (unknown [195.135.221.27])
        by mx2.suse.de (Postfix) with ESMTP id ACC2EAE4A;
        Fri, 11 Dec 2020 17:48:06 +0000 (UTC)
Received: by ds.suse.cz (Postfix, from userid 10065)
        id 89EF9DA7CF; Fri, 11 Dec 2020 18:46:29 +0100 (CET)
Date:   Fri, 11 Dec 2020 18:46:29 +0100
From:   David Sterba <dsterba@suse.cz>
To:     dsterba@suse.cz, Sidong Yang <realwakka@gmail.com>,
        linux-btrfs@vger.kernel.org
Subject: Re: [PATCH v3 2/2] btrfs-progs: device stats: add json output format
Message-ID: <20201211174629.GQ6430@twin.jikos.cz>
Reply-To: dsterba@suse.cz
Mail-Followup-To: dsterba@suse.cz, Sidong Yang <realwakka@gmail.com>,
        linux-btrfs@vger.kernel.org
References: <20201211164812.459012-1-realwakka@gmail.com>
 <20201211164812.459012-2-realwakka@gmail.com>
 <20201211173025.GO6430@twin.jikos.cz>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20201211173025.GO6430@twin.jikos.cz>
User-Agent: Mutt/1.5.23.1-rc1 (2014-03-12)
Precedence: bulk
List-ID: <linux-btrfs.vger.kernel.org>
X-Mailing-List: linux-btrfs@vger.kernel.org

On Fri, Dec 11, 2020 at 06:30:25PM +0100, David Sterba wrote:
> On Fri, Dec 11, 2020 at 04:48:12PM +0000, Sidong Yang wrote:
> > Example json format:
> > 
> > {
> >   "__header": {
> >     "version": "1"
> >   },
> >   "device-stats": [
> >     {
> >       "device": "/dev/vdb",
> >       "devid": "1",
> >       "write_io_errs": "0",
> >       "read_io_errs": "0",
> >       "flush_io_errs": "0",
> >       "corruption_errs": "0",
> >       "generation_errs": "0"
> >     }
> >   ],
>      ^
> 
> I've verified that the comma is really there, it's not a valid json so
> there's a bug in the formatter. To verify that the output is valid you
> can use eg. 'jq', simply pipe the output of the commadn there.
> 
>   $ ./btrfs --format json dev stats /mnt | jq
>   parse error: Expected another key-value pair at line 16, column 1

I've pushed the updated plain text formatting to devel, so the only
remaining bug is the above extra comma.