From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2A16C2BB48 for ; Mon, 14 Dec 2020 17:40:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6647321534 for ; Mon, 14 Dec 2020 17:40:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2502384AbgLNRjw (ORCPT ); Mon, 14 Dec 2020 12:39:52 -0500 Received: from mx2.suse.de ([195.135.220.15]:49362 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2408632AbgLNRjg (ORCPT ); Mon, 14 Dec 2020 12:39:36 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 8A883AC10; Mon, 14 Dec 2020 17:38:54 +0000 (UTC) Received: by ds.suse.cz (Postfix, from userid 10065) id C2FACDA7C3; Mon, 14 Dec 2020 18:37:15 +0100 (CET) Date: Mon, 14 Dec 2020 18:37:15 +0100 From: David Sterba To: Pavel Begunkov Cc: Chris Mason , Josef Bacik , David Sterba , linux-btrfs@vger.kernel.org Subject: Re: [PATCH v3 for-next 0/3] btrfs async discard fixes & improvements Message-ID: <20201214173715.GR6430@twin.jikos.cz> Reply-To: dsterba@suse.cz Mail-Followup-To: dsterba@suse.cz, Pavel Begunkov , Chris Mason , Josef Bacik , David Sterba , linux-btrfs@vger.kernel.org References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23.1-rc1 (2014-03-12) Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org On Sun, Dec 06, 2020 at 03:56:19PM +0000, Pavel Begunkov wrote: > Fix async discard stalls with the first patch, and address other minor > things. > > v2: fix async discard stalls, see patch [1/3] > v3: if now == bg->discard_eligible_time it fails to init discard state, > and index. Always init it if peek return !=NULL bg, it's more > resilient. > > Pavel Begunkov (3): > btrfs: fix async discard stall > btrfs: fix racy access to discard_ctl data > btrfs: don't overabuse discard lock Thanks. I'll add the patchset to for-next and will send it with some post rc1 pull request.