From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2AE6EC2BB9A for ; Tue, 15 Dec 2020 19:03:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F11A122AAE for ; Tue, 15 Dec 2020 19:03:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731846AbgLOTCq (ORCPT ); Tue, 15 Dec 2020 14:02:46 -0500 Received: from mx2.suse.de ([195.135.220.15]:52610 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729637AbgLOTC0 (ORCPT ); Tue, 15 Dec 2020 14:02:26 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 2F4FDAC7F; Tue, 15 Dec 2020 19:01:39 +0000 (UTC) Received: by ds.suse.cz (Postfix, from userid 10065) id 1A9C1DA7C3; Tue, 15 Dec 2020 20:00:00 +0100 (CET) Date: Tue, 15 Dec 2020 20:00:00 +0100 From: David Sterba To: Nikolay Borisov Cc: linux-btrfs@vger.kernel.org Subject: Re: [PATCH 0/2] Support removal of ino cache leftover by btrfs check Message-ID: <20201215185959.GE6430@twin.jikos.cz> Reply-To: dsterba@suse.cz Mail-Followup-To: dsterba@suse.cz, Nikolay Borisov , linux-btrfs@vger.kernel.org References: <20201203081742.3759528-1-nborisov@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201203081742.3759528-1-nborisov@suse.com> User-Agent: Mutt/1.5.23.1-rc1 (2014-03-12) Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org On Thu, Dec 03, 2020 at 10:17:40AM +0200, Nikolay Borisov wrote: > Following the removal of ino cache support in the kernel, let's add support > for 'btrfs check --clear-ino-cache'. 2nd patch also adds a test to ensure we > don't regress this functionality in the future. Thanks, added to devel with some fixups. The test is really for check so it should be in fsck-tests and the SUDO_HELPER is not necessary as there's no mount/umount involved (that failed on my NFS setup), the dump-tree -t N should not be numeric if it's for a named tree (fs, csum).