linux-btrfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Zygo Blaxell <ce3g8jdj@umail.furryterror.org>
To: Josef Bacik <josef@toxicpanda.com>
Cc: linux-btrfs@vger.kernel.org, kernel-team@fb.com
Subject: Re: [PATCH v7 00/38] Cleanup error handling in relocation
Date: Wed, 16 Dec 2020 14:56:03 -0500	[thread overview]
Message-ID: <20201216195603.GP31381@hungrycats.org> (raw)
In-Reply-To: <cover.1608135849.git.josef@toxicpanda.com>

On Wed, Dec 16, 2020 at 11:26:16AM -0500, Josef Bacik wrote:
> v6->v7:
> - Broke up the series into 3 series, 1 for cosmetic things, 1 for all the major
>   issues (including those reported on v6 of this set), and this new set which is
>   solely the error handling related patches for relocation.  It's still a lot of
>   patches, sorry about that.

So far it lockdepped, but it is still running:

	[Wed Dec 16 13:30:45 2020] irq event stamp: 5875656

	[Wed Dec 16 13:30:45 2020] ======================================================
	[Wed Dec 16 13:30:45 2020] hardirqs last  enabled at (5875655): [<ffffffff98a82e37>] _raw_spin_unlock_irqrestore+0x47/0x50
	[Wed Dec 16 13:30:45 2020] WARNING: possible circular locking dependency detected
	[Wed Dec 16 13:30:45 2020] hardirqs last disabled at (5875656): [<ffffffff98a8368d>] _raw_spin_lock_irqsave+0x7d/0xa0
	[Wed Dec 16 13:30:45 2020] softirqs last  enabled at (5874382): [<ffffffff98e0044f>] __do_softirq+0x44f/0x5a7
	[Wed Dec 16 13:30:45 2020] 5.10.0-39fbe74d1bbc-josef+ #1 Tainted: G        W        
	[Wed Dec 16 13:30:45 2020] softirqs last disabled at (5874369): [<ffffffff98c01122>] asm_call_irq_on_stack+0x12/0x20
	[Wed Dec 16 13:30:45 2020] ------------------------------------------------------
	[Wed Dec 16 13:30:45 2020] btrfs/6366 is trying to acquire lock:
	[Wed Dec 16 13:30:45 2020] ffff88816f146a28 (btrfs-treloc-03){+.+.}-{3:3}, at: __btrfs_tree_lock+0x29/0x190
	[Wed Dec 16 13:30:45 2020]
				   but task is already holding lock:
	[Wed Dec 16 13:30:45 2020] ffff88810167c598 (btrfs-tree-02){++++}-{3:3}, at: __btrfs_tree_lock+0x29/0x190
	[Wed Dec 16 13:30:45 2020]
				   which lock already depends on the new lock.

	[Wed Dec 16 13:30:45 2020]
				   the existing dependency chain (in reverse order) is:
	[Wed Dec 16 13:30:45 2020]
				   -> #1 (btrfs-tree-02){++++}-{3:3}:
	[Wed Dec 16 13:30:45 2020]        down_write_nested+0xa6/0x2d0
	[Wed Dec 16 13:30:45 2020]        __btrfs_tree_lock+0x29/0x190
	[Wed Dec 16 13:30:45 2020]        btrfs_tree_lock+0x10/0x20
	[Wed Dec 16 13:30:45 2020]        btrfs_search_slot+0x474/0x1090
	[Wed Dec 16 13:30:45 2020]        do_relocation+0x2a0/0xc20
	[Wed Dec 16 13:30:45 2020]        relocate_tree_blocks+0x733/0xb90
	[Wed Dec 16 13:30:45 2020]        relocate_block_group+0x2eb/0x780
	[Wed Dec 16 13:30:45 2020]        btrfs_relocate_block_group+0x26e/0x4c0
	[Wed Dec 16 13:30:45 2020]        btrfs_relocate_chunk+0x52/0x120
	[Wed Dec 16 13:30:45 2020]        btrfs_balance+0xe2e/0x1900
	[Wed Dec 16 13:30:45 2020]        btrfs_ioctl_balance+0x1f9/0x460
	[Wed Dec 16 13:30:45 2020]        btrfs_ioctl+0xe9c/0x4360
	[Wed Dec 16 13:30:45 2020]        __x64_sys_ioctl+0xc3/0x100
	[Wed Dec 16 13:30:45 2020]        do_syscall_64+0x37/0x80
	[Wed Dec 16 13:30:45 2020]        entry_SYSCALL_64_after_hwframe+0x44/0xa9
	[Wed Dec 16 13:30:45 2020]
				   -> #0 (btrfs-treloc-03){+.+.}-{3:3}:
	[Wed Dec 16 13:30:45 2020]        __lock_acquire+0x1ebb/0x2880
	[Wed Dec 16 13:30:45 2020]        lock_acquire+0x192/0x550
	[Wed Dec 16 13:30:45 2020]        down_write_nested+0xa6/0x2d0
	[Wed Dec 16 13:30:45 2020]        __btrfs_tree_lock+0x29/0x190
	[Wed Dec 16 13:30:45 2020]        btrfs_lock_root_node+0x5b/0x190
	[Wed Dec 16 13:30:45 2020]        btrfs_search_slot+0xc8d/0x1090
	[Wed Dec 16 13:30:45 2020]        replace_path.isra.36+0x8a2/0xee0
	[Wed Dec 16 13:30:45 2020]        merge_reloc_root+0x58c/0xc10
	[Wed Dec 16 13:30:45 2020]        merge_reloc_roots+0x1e6/0x4a0
	[Wed Dec 16 13:30:45 2020]        relocate_block_group+0x3d2/0x780
	[Wed Dec 16 13:30:45 2020]        btrfs_relocate_block_group+0x26e/0x4c0
	[Wed Dec 16 13:30:45 2020]        btrfs_relocate_chunk+0x52/0x120
	[Wed Dec 16 13:30:45 2020]        btrfs_balance+0xe2e/0x1900
	[Wed Dec 16 13:30:45 2020]        btrfs_ioctl_balance+0x1f9/0x460
	[Wed Dec 16 13:30:45 2020]        btrfs_ioctl+0xe9c/0x4360
	[Wed Dec 16 13:30:45 2020]        __x64_sys_ioctl+0xc3/0x100
	[Wed Dec 16 13:30:45 2020]        do_syscall_64+0x37/0x80
	[Wed Dec 16 13:30:45 2020]        entry_SYSCALL_64_after_hwframe+0x44/0xa9
	[Wed Dec 16 13:30:45 2020]
				   other info that might help us debug this:

	[Wed Dec 16 13:30:45 2020]  Possible unsafe locking scenario:

	[Wed Dec 16 13:30:45 2020]        CPU0                    CPU1
	[Wed Dec 16 13:30:45 2020]        ----                    ----
	[Wed Dec 16 13:30:45 2020]   lock(btrfs-tree-02);
	[Wed Dec 16 13:30:45 2020]                                lock(btrfs-treloc-03);
	[Wed Dec 16 13:30:45 2020]                                lock(btrfs-tree-02);
	[Wed Dec 16 13:30:45 2020]   lock(btrfs-treloc-03);
	[Wed Dec 16 13:30:45 2020]
				    *** DEADLOCK ***

	[Wed Dec 16 13:30:45 2020] 5 locks held by btrfs/6366:
	[Wed Dec 16 13:30:45 2020]  #0: ffff888128318498 (sb_writers#13){.+.+}-{0:0}, at: btrfs_ioctl_balance+0x71/0x460
	[Wed Dec 16 13:30:45 2020]  #1: ffff88810d2f22c8 (&fs_info->delete_unused_bgs_mutex){+.+.}-{3:3}, at: btrfs_balance+0xa54/0x1900
	[Wed Dec 16 13:30:45 2020]  #2: ffff88810d2f08f0 (&fs_info->cleaner_mutex){+.+.}-{3:3}, at: btrfs_relocate_block_group+0x266/0x4c0
	[Wed Dec 16 13:30:45 2020]  #3: ffff8881283186b8 (sb_internal#2){.+.+}-{0:0}, at: btrfs_start_transaction+0x1e/0x20
	[Wed Dec 16 13:30:45 2020]  #4: ffff88810167c598 (btrfs-tree-02){++++}-{3:3}, at: __btrfs_tree_lock+0x29/0x190
	[Wed Dec 16 13:30:45 2020]
				   stack backtrace:
	[Wed Dec 16 13:30:45 2020] CPU: 0 PID: 6366 Comm: btrfs Tainted: G        W         5.10.0-39fbe74d1bbc-josef+ #1
	[Wed Dec 16 13:30:45 2020] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.12.0-1 04/01/2014
	[Wed Dec 16 13:30:45 2020] Call Trace:
	[Wed Dec 16 13:30:45 2020]  dump_stack+0xbc/0xf9
	[Wed Dec 16 13:30:45 2020]  print_circular_bug.isra.42.cold.67+0x146/0x14b
	[Wed Dec 16 13:30:45 2020]  check_noncircular+0x219/0x250
	[Wed Dec 16 13:30:45 2020]  ? print_circular_bug.isra.42+0x230/0x230
	[Wed Dec 16 13:30:45 2020]  ? pvclock_clocksource_read+0xeb/0x190
	[Wed Dec 16 13:30:45 2020]  ? __kasan_check_write+0x14/0x20
	[Wed Dec 16 13:30:45 2020]  ? lockdep_lock+0xaa/0x160
	[Wed Dec 16 13:30:45 2020]  __lock_acquire+0x1ebb/0x2880
	[Wed Dec 16 13:30:45 2020]  ? register_lock_class+0x8f0/0x8f0
	[Wed Dec 16 13:30:45 2020]  ? rcu_read_lock_sched_held+0xa1/0xd0
	[Wed Dec 16 13:30:45 2020]  ? rcu_read_lock_bh_held+0xb0/0xb0
	[Wed Dec 16 13:30:45 2020]  lock_acquire+0x192/0x550
	[Wed Dec 16 13:30:45 2020]  ? __btrfs_tree_lock+0x29/0x190
	[Wed Dec 16 13:30:45 2020]  ? check_flags+0x30/0x30
	[Wed Dec 16 13:30:45 2020]  ? ___might_sleep+0x10f/0x1e0
	[Wed Dec 16 13:30:46 2020]  ? __might_sleep+0x71/0xe0
	[Wed Dec 16 13:30:46 2020]  down_write_nested+0xa6/0x2d0
	[Wed Dec 16 13:30:46 2020]  ? __btrfs_tree_lock+0x29/0x190
	[Wed Dec 16 13:30:46 2020]  ? btrfs_root_node+0x23/0x200
	[Wed Dec 16 13:30:46 2020]  ? _down_write_nest_lock+0x2c0/0x2c0
	[Wed Dec 16 13:30:46 2020]  ? rcu_read_lock_sched_held+0xd0/0xd0
	[Wed Dec 16 13:30:46 2020]  __btrfs_tree_lock+0x29/0x190
	[Wed Dec 16 13:30:46 2020]  btrfs_lock_root_node+0x5b/0x190
	[Wed Dec 16 13:30:46 2020]  btrfs_search_slot+0xc8d/0x1090
	[Wed Dec 16 13:30:46 2020]  ? __kasan_check_read+0x11/0x20
	[Wed Dec 16 13:30:46 2020]  ? check_flags.part.50+0x6c/0x1e0
	[Wed Dec 16 13:30:46 2020]  ? split_leaf+0xa20/0xa20
	[Wed Dec 16 13:30:46 2020]  ? _raw_spin_unlock+0x22/0x30
	[Wed Dec 16 13:30:46 2020]  ? release_extent_buffer+0x225/0x280
	[Wed Dec 16 13:30:46 2020]  ? __kasan_check_write+0x14/0x20
	[Wed Dec 16 13:30:46 2020]  ? free_extent_buffer.part.53+0x90/0x140
	[Wed Dec 16 13:30:46 2020]  ? free_extent_buffer+0x13/0x20
	[Wed Dec 16 13:30:46 2020]  replace_path.isra.36+0x8a2/0xee0
	[Wed Dec 16 13:30:46 2020]  ? describe_relocation.isra.30+0xf0/0xf0
	[Wed Dec 16 13:30:46 2020]  ? check_setget_bounds+0x2a/0x60
	[Wed Dec 16 13:30:46 2020]  ? btrfs_get_64+0x1e8/0x200
	[Wed Dec 16 13:30:46 2020]  ? btrfs_get_token_64+0x350/0x350
	[Wed Dec 16 13:30:46 2020]  ? memcpy+0x4d/0x60
	[Wed Dec 16 13:30:46 2020]  merge_reloc_root+0x58c/0xc10
	[Wed Dec 16 13:30:46 2020]  ? prepare_to_merge+0x660/0x660
	[Wed Dec 16 13:30:46 2020]  ? btrfs_lookup_fs_root+0x113/0x180
	[Wed Dec 16 13:30:46 2020]  ? btrfs_end_super_write+0x3c0/0x3c0
	[Wed Dec 16 13:30:46 2020]  ? mutex_lock_io_nested+0xc20/0xc20
	[Wed Dec 16 13:30:46 2020]  ? btrfs_get_root_ref+0x24a/0x470
	[Wed Dec 16 13:30:46 2020]  ? __mutex_unlock_slowpath+0xb2/0x400
	[Wed Dec 16 13:30:46 2020]  ? btrfs_find_highest_objectid+0x1b0/0x1b0
	[Wed Dec 16 13:30:46 2020]  ? btrfs_init_reloc_root+0x370/0x370
	[Wed Dec 16 13:30:46 2020]  ? __kasan_check_write+0x14/0x20
	[Wed Dec 16 13:30:46 2020]  merge_reloc_roots+0x1e6/0x4a0
	[Wed Dec 16 13:30:46 2020]  ? merge_reloc_root+0xc10/0xc10
	[Wed Dec 16 13:30:46 2020]  ? btrfs_block_rsv_release+0x3a7/0x620
	[Wed Dec 16 13:30:46 2020]  relocate_block_group+0x3d2/0x780
	[Wed Dec 16 13:30:46 2020]  ? btrfs_defrag_leaves+0x250/0x650
	[Wed Dec 16 13:30:46 2020]  ? merge_reloc_roots+0x4a0/0x4a0
	[Wed Dec 16 13:30:46 2020]  btrfs_relocate_block_group+0x26e/0x4c0
	[Wed Dec 16 13:30:46 2020]  btrfs_relocate_chunk+0x52/0x120
	[Wed Dec 16 13:30:46 2020]  btrfs_balance+0xe2e/0x1900
	[Wed Dec 16 13:30:46 2020]  ? pvclock_clocksource_read+0xeb/0x190
	[Wed Dec 16 13:30:46 2020]  ? btrfs_relocate_chunk+0x120/0x120
	[Wed Dec 16 13:30:46 2020]  ? lock_acquired+0x7f/0x5e0
	[Wed Dec 16 13:30:46 2020]  ? do_raw_spin_lock+0x1e0/0x1e0
	[Wed Dec 16 13:30:46 2020]  ? do_raw_spin_unlock+0xa8/0x140
	[Wed Dec 16 13:30:46 2020]  btrfs_ioctl_balance+0x1f9/0x460
	[Wed Dec 16 13:30:46 2020]  btrfs_ioctl+0xe9c/0x4360
	[Wed Dec 16 13:30:46 2020]  ? __kasan_check_read+0x11/0x20
	[Wed Dec 16 13:30:46 2020]  ? check_chain_key+0x1f4/0x2f0
	[Wed Dec 16 13:30:46 2020]  ? __asan_loadN+0xf/0x20
	[Wed Dec 16 13:30:46 2020]  ? btrfs_ioctl_get_supported_features+0x30/0x30
	[Wed Dec 16 13:30:46 2020]  ? kvm_sched_clock_read+0x18/0x30
	[Wed Dec 16 13:30:46 2020]  ? check_chain_key+0x1f4/0x2f0
	[Wed Dec 16 13:30:46 2020]  ? lock_downgrade+0x3f0/0x3f0
	[Wed Dec 16 13:30:46 2020]  ? handle_mm_fault+0xad6/0x2150
	[Wed Dec 16 13:30:46 2020]  ? do_vfs_ioctl+0xfc/0x9d0
	[Wed Dec 16 13:30:46 2020]  ? ioctl_file_clone+0xe0/0xe0
	[Wed Dec 16 13:30:46 2020]  ? check_flags.part.50+0x6c/0x1e0
	[Wed Dec 16 13:30:46 2020]  ? check_flags.part.50+0x6c/0x1e0
	[Wed Dec 16 13:30:46 2020]  ? check_flags+0x26/0x30
	[Wed Dec 16 13:30:46 2020]  ? lock_is_held_type+0xc3/0xf0
	[Wed Dec 16 13:30:46 2020]  ? syscall_enter_from_user_mode+0x1b/0x60
	[Wed Dec 16 13:30:46 2020]  ? do_syscall_64+0x13/0x80
	[Wed Dec 16 13:30:46 2020]  ? rcu_read_lock_sched_held+0xa1/0xd0
	[Wed Dec 16 13:30:46 2020]  ? __kasan_check_read+0x11/0x20
	[Wed Dec 16 13:30:46 2020]  ? __fget_light+0xae/0x110
	[Wed Dec 16 13:30:46 2020]  __x64_sys_ioctl+0xc3/0x100
	[Wed Dec 16 13:30:46 2020]  do_syscall_64+0x37/0x80
	[Wed Dec 16 13:30:46 2020]  entry_SYSCALL_64_after_hwframe+0x44/0xa9
	[Wed Dec 16 13:30:46 2020] RIP: 0033:0x7f7c98b07427
	[Wed Dec 16 13:30:46 2020] Code: 00 00 90 48 8b 05 69 aa 0c 00 64 c7 00 26 00 00 00 48 c7 c0 ff ff ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 b8 10 00 00 00 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 8b 0d 39 aa 0c 00 f7 d8 64 89 01 48
	[Wed Dec 16 13:30:46 2020] RSP: 002b:00007fff0cb87938 EFLAGS: 00000202 ORIG_RAX: 0000000000000010
	[Wed Dec 16 13:30:46 2020] RAX: ffffffffffffffda RBX: 0000000000000000 RCX: 00007f7c98b07427
	[Wed Dec 16 13:30:46 2020] RDX: 00007fff0cb87948 RSI: 00000000c4009420 RDI: 0000000000000003
	[Wed Dec 16 13:30:46 2020] RBP: 0000000000000003 R08: 0000000000000003 R09: 0000000000000078
	[Wed Dec 16 13:30:46 2020] R10: fffffffffffff59d R11: 0000000000000202 R12: 0000000000000002
	[Wed Dec 16 13:30:46 2020] R13: 00007fff0cb89a3f R14: 0000557c21f8c119 R15: 0000000000000000
	[Wed Dec 16 13:31:03 2020] BTRFS info (device dm-0): found 2 extents, loops 2, stage: update data pointers
	[Wed Dec 16 13:31:59 2020] BTRFS info (device dm-0): relocating block group 981598208000 flags data

  parent reply	other threads:[~2020-12-16 19:57 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-16 16:26 [PATCH v7 00/38] Cleanup error handling in relocation Josef Bacik
2020-12-16 16:26 ` [PATCH v7 01/38] btrfs: convert BUG_ON()'s in relocate_tree_block Josef Bacik
2020-12-16 16:26 ` [PATCH v7 02/38] btrfs: return an error from btrfs_record_root_in_trans Josef Bacik
2021-02-26 19:03   ` David Sterba
2020-12-16 16:26 ` [PATCH v7 03/38] btrfs: handle errors from select_reloc_root() Josef Bacik
2021-02-26 18:30   ` David Sterba
2021-03-11 18:10     ` Josef Bacik
2021-04-09 19:24       ` David Sterba
2020-12-16 16:26 ` [PATCH v7 04/38] btrfs: convert BUG_ON()'s in select_reloc_root() to proper errors Josef Bacik
2020-12-16 16:26 ` [PATCH v7 05/38] btrfs: check record_root_in_trans related failures in select_reloc_root Josef Bacik
2020-12-16 16:26 ` [PATCH v7 06/38] btrfs: do proper error handling in record_reloc_root_in_trans Josef Bacik
2020-12-16 16:26 ` [PATCH v7 07/38] btrfs: handle btrfs_record_root_in_trans failure in btrfs_rename_exchange Josef Bacik
2020-12-16 16:26 ` [PATCH v7 08/38] btrfs: handle btrfs_record_root_in_trans failure in btrfs_rename Josef Bacik
2020-12-16 16:26 ` [PATCH v7 09/38] btrfs: handle btrfs_record_root_in_trans failure in btrfs_delete_subvolume Josef Bacik
2020-12-16 16:26 ` [PATCH v7 10/38] btrfs: handle btrfs_record_root_in_trans failure in btrfs_recover_log_trees Josef Bacik
2020-12-16 16:26 ` [PATCH v7 11/38] btrfs: handle btrfs_record_root_in_trans failure in create_subvol Josef Bacik
2020-12-16 16:26 ` [PATCH v7 12/38] btrfs: btrfs: handle btrfs_record_root_in_trans failure in relocate_tree_block Josef Bacik
2020-12-16 16:26 ` [PATCH v7 13/38] btrfs: handle btrfs_record_root_in_trans failure in start_transaction Josef Bacik
2020-12-16 16:26 ` [PATCH v7 14/38] btrfs: handle record_root_in_trans failure in qgroup_account_snapshot Josef Bacik
2020-12-16 16:26 ` [PATCH v7 15/38] btrfs: handle record_root_in_trans failure in btrfs_record_root_in_trans Josef Bacik
2020-12-16 16:26 ` [PATCH v7 16/38] btrfs: handle record_root_in_trans failure in create_pending_snapshot Josef Bacik
2020-12-16 16:26 ` [PATCH v7 17/38] btrfs: do not panic in __add_reloc_root Josef Bacik
2020-12-16 16:26 ` [PATCH v7 18/38] btrfs: have proper error handling in btrfs_init_reloc_root Josef Bacik
2020-12-16 16:26 ` [PATCH v7 19/38] btrfs: do proper error handling in create_reloc_root Josef Bacik
2020-12-16 16:26 ` [PATCH v7 20/38] btrfs: validate ->reloc_root after recording root in trans Josef Bacik
2020-12-16 16:26 ` [PATCH v7 21/38] btrfs: handle btrfs_update_reloc_root failure in commit_fs_roots Josef Bacik
2020-12-16 16:26 ` [PATCH v7 22/38] btrfs: change insert_dirty_subvol to return errors Josef Bacik
2020-12-16 16:26 ` [PATCH v7 23/38] btrfs: handle btrfs_update_reloc_root failure in insert_dirty_subvol Josef Bacik
2020-12-16 16:26 ` [PATCH v7 24/38] btrfs: handle btrfs_update_reloc_root failure in prepare_to_merge Josef Bacik
2020-12-16 16:26 ` [PATCH v7 25/38] btrfs: do proper error handling in btrfs_update_reloc_root Josef Bacik
2020-12-16 16:26 ` [PATCH v7 26/38] btrfs: convert logic BUG_ON()'s in replace_path to ASSERT()'s Josef Bacik
2020-12-16 16:26 ` [PATCH v7 27/38] btrfs: handle btrfs_cow_block errors in replace_path Josef Bacik
2020-12-16 16:26 ` [PATCH v7 28/38] btrfs: handle btrfs_search_slot failure " Josef Bacik
2020-12-16 16:26 ` [PATCH v7 29/38] btrfs: handle errors in reference count manipulation " Josef Bacik
2020-12-16 16:26 ` [PATCH v7 30/38] btrfs: handle extent reference errors in do_relocation Josef Bacik
2020-12-16 16:26 ` [PATCH v7 31/38] btrfs: check for BTRFS_BLOCK_FLAG_FULL_BACKREF being set improperly Josef Bacik
2020-12-16 16:26 ` [PATCH v7 32/38] btrfs: remove the extent item sanity checks in relocate_block_group Josef Bacik
2020-12-16 16:26 ` [PATCH v7 33/38] btrfs: do proper error handling in create_reloc_inode Josef Bacik
2020-12-16 16:26 ` [PATCH v7 34/38] btrfs: handle __add_reloc_root failures in btrfs_recover_relocation Josef Bacik
2020-12-16 16:26 ` [PATCH v7 35/38] btrfs: cleanup error handling in prepare_to_merge Josef Bacik
2020-12-16 16:26 ` [PATCH v7 36/38] btrfs: handle extent corruption with select_one_root properly Josef Bacik
2020-12-16 16:26 ` [PATCH v7 37/38] btrfs: do proper error handling in merge_reloc_roots Josef Bacik
2020-12-16 16:26 ` [PATCH v7 38/38] btrfs: check return value of btrfs_commit_transaction in relocation Josef Bacik
2020-12-16 19:56 ` Zygo Blaxell [this message]
2020-12-18 16:25   ` [PATCH v7 00/38] Cleanup error handling " Zygo Blaxell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201216195603.GP31381@hungrycats.org \
    --to=ce3g8jdj@umail.furryterror.org \
    --cc=josef@toxicpanda.com \
    --cc=kernel-team@fb.com \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).