From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5CBA0C433E0 for ; Mon, 4 Jan 2021 15:14:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2BD13221E5 for ; Mon, 4 Jan 2021 15:14:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727369AbhADPNo (ORCPT ); Mon, 4 Jan 2021 10:13:44 -0500 Received: from mx2.suse.de ([195.135.220.15]:42508 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725830AbhADPNn (ORCPT ); Mon, 4 Jan 2021 10:13:43 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 2B1D5ACAF; Mon, 4 Jan 2021 15:13:02 +0000 (UTC) Received: by ds.suse.cz (Postfix, from userid 10065) id 98DEBDA882; Mon, 4 Jan 2021 16:11:13 +0100 (CET) Date: Mon, 4 Jan 2021 16:11:13 +0100 From: David Sterba To: Defang Bo Cc: clm@fb.com, josef@toxicpanda.com, dsterba@suse.com, linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/3] fs/btrfs: avoid null pointer dereference if reloc control has not been initialized Message-ID: <20210104151113.GG6430@twin.jikos.cz> Reply-To: dsterba@suse.cz Mail-Followup-To: dsterba@suse.cz, Defang Bo , clm@fb.com, josef@toxicpanda.com, dsterba@suse.com, linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org References: <1609080931-4048864-1-git-send-email-bodefang@126.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1609080931-4048864-1-git-send-email-bodefang@126.com> User-Agent: Mutt/1.5.23.1-rc1 (2014-03-12) Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org On Sun, Dec 27, 2020 at 10:55:31PM +0800, Defang Bo wrote: > Similar to commmit<389305b2>, Please use full commit reference like 389305b2aa68 ("btrfs: relocation: Only remove reloc rb_trees if reloc control has been initialized") > it turns out that fs_info::reloc_ctl can be NULL , Please describe how the NULL can get there.