From: David Sterba <dsterba@suse.cz>
To: Josef Bacik <josef@toxicpanda.com>
Cc: linux-btrfs@vger.kernel.org, kernel-team@fb.com
Subject: Re: [PATCH] btrfs-progs: properly exclude leaves for lowmem
Date: Wed, 6 Jan 2021 17:17:18 +0100 [thread overview]
Message-ID: <20210106161718.GT6430@twin.jikos.cz> (raw)
In-Reply-To: <845796bfab85f02919d64908b63f3f7201a2abb3.1609882807.git.josef@toxicpanda.com>
On Tue, Jan 05, 2021 at 04:40:18PM -0500, Josef Bacik wrote:
> The lowmem mode excludes all referenced blocks from the allocator in
> order to avoid accidentally overwriting blocks while fixing the file
> system. However for leaves it wouldn't exclude anything, it would just
> pin them down, which gets cleaned up on transaction commit. We're safe
> for the first modification, but subsequent modifications could blow up
> in our face. Fix this by properly excluding leaves as well as all of
> the nodes.
This sounds like a test case can be easily written.
prev parent reply other threads:[~2021-01-06 16:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-05 21:40 [PATCH] btrfs-progs: properly exclude leaves for lowmem Josef Bacik
2021-01-06 1:42 ` Su Yue
2021-01-06 16:17 ` David Sterba [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210106161718.GT6430@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=josef@toxicpanda.com \
--cc=kernel-team@fb.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox