From: David Sterba <dsterba@suse.cz>
To: Marcos Paulo de Souza <marcos@mpdesouza.com>
Cc: linux-btrfs@vger.kernel.org,
Marcos Paulo de Souza <mpdesouza@suse.com>,
wqu@suse.com, dsterba@suse.com
Subject: Re: [PATCH v4 0/3] btrfs-progs: Fix logical-resolve
Date: Thu, 14 Jan 2021 19:42:32 +0100 [thread overview]
Message-ID: <20210114184232.GC6430@twin.jikos.cz> (raw)
In-Reply-To: <20201127193035.19171-1-marcos@mpdesouza.com>
On Fri, Nov 27, 2020 at 04:30:32PM -0300, Marcos Paulo de Souza wrote:
> From: Marcos Paulo de Souza <mpdesouza@suse.com>
>
> In this forth iteration, only patch 0002 was changed. Previously the variable
> full_path, which is passed by the user, was being overwritten in the inode loop.
> Now we create a temp var to store the mount_point when the lookup is needed.
>
> Please review.
>
> Changes from v3:
> * In patch 0002, do not overwrite full_path variable
For the record, patches have been reworked as there some differences
between kernels 5.3 and 5.8 regarding bind mounts and what is printed in
/proc/ mounts due to 3ef3959b29c4 ("btrfs: don't show full path of bind
mounts in subvol=").
New version uses libmount to parse the information and distinguish
subvol= mounts and bind mounts. With a test.
prev parent reply other threads:[~2021-01-14 18:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-27 19:30 [PATCH v4 0/3] btrfs-progs: Fix logical-resolve Marcos Paulo de Souza
2020-11-27 19:30 ` [PATCH v4 1/3] btrfs-progs: Adapt find_mount_root to verify other fields of mntent struct Marcos Paulo de Souza
2020-11-27 19:30 ` [PATCH v4 2/3] btrfs-progs: inspect: Fix logical-resolve file path lookup Marcos Paulo de Souza
2020-12-04 0:08 ` Qu Wenruo
2020-11-27 19:30 ` [PATCH v4 3/3] btrfs-progs: tests: Add new logical-resolve test Marcos Paulo de Souza
2020-12-02 20:12 ` [PATCH v4 0/3] btrfs-progs: Fix logical-resolve Josef Bacik
2021-01-14 18:42 ` David Sterba [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210114184232.GC6430@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=dsterba@suse.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=marcos@mpdesouza.com \
--cc=mpdesouza@suse.com \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox